Bug 41563 - Tidy kohaTable block - acqui
Summary: Tidy kohaTable block - acqui
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 39715 41562
Blocks: 41324
  Show dependency treegraph
 
Reported: 2026-01-09 13:53 UTC by Jonathan Druart
Modified: 2026-01-12 16:56 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt (1.48 KB, patch)
2026-01-09 14:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/basket.tt (4.20 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt (2.26 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt (2.36 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/histsearch.tt (1.28 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/invoice.tt (2.20 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/lateorders.tt (1.40 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt (1.67 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt (10.80 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/parcel.tt (9.46 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt (1.27 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: acqui - auto tidy (124.88 KB, patch)
2026-01-09 14:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt (1.52 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/basket.tt (4.25 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt (2.30 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt (2.41 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/histsearch.tt (1.33 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/invoice.tt (2.25 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/lateorders.tt (1.45 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt (1.72 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt (10.84 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/parcel.tt (9.51 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt (1.32 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: acqui - auto tidy (124.93 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: (follow-up) Fix two typos (2.15 KB, patch)
2026-01-12 16:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41563: (follow-up) Tidy parcel.tt (35.54 KB, patch)
2026-01-12 16:56 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2026-01-09 13:53:33 UTC

    
Comment 1 Jonathan Druart 2026-01-09 14:39:59 UTC
Created attachment 191069 [details] [review]
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt

See bug 41324 comment 6
1. Variable serialization
Comment 2 Jonathan Druart 2026-01-09 14:40:00 UTC
Created attachment 191070 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basket.tt

See bug 41324 comment 6
1. Variable serialization
3. "table_settings" variable
Comment 3 Jonathan Druart 2026-01-09 14:40:01 UTC
Created attachment 191071 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt

See bug 41324 comment 6
1. Variable serialization
Comment 4 Jonathan Druart 2026-01-09 14:40:03 UTC
Created attachment 191072 [details] [review]
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt

See bug 41324 comment 6
1. Variable serialization
Comment 5 Jonathan Druart 2026-01-09 14:40:04 UTC
Created attachment 191073 [details] [review]
Bug 41563: Tidy kohaTable - acqui/histsearch.tt

See bug 41324 comment 6
1. Variable serialization
Comment 6 Jonathan Druart 2026-01-09 14:40:05 UTC
Created attachment 191074 [details] [review]
Bug 41563: Tidy kohaTable - acqui/invoice.tt

See bug 41324 comment 6
1. Variable serialization
Comment 7 Jonathan Druart 2026-01-09 14:40:07 UTC
Created attachment 191075 [details] [review]
Bug 41563: Tidy kohaTable - acqui/lateorders.tt

See bug 41324 comment 6
1. Variable serialization
Comment 8 Jonathan Druart 2026-01-09 14:40:08 UTC
Created attachment 191076 [details] [review]
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt

See bug 41324 comment 6
1. Variable serialization
Comment 9 Jonathan Druart 2026-01-09 14:40:10 UTC
Created attachment 191077 [details] [review]
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs

We also removed 'UniqueItemFields' from the controller.
Comment 10 Jonathan Druart 2026-01-09 14:40:11 UTC
Created attachment 191078 [details] [review]
Bug 41563: Tidy kohaTable - acqui/parcel.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs
Comment 11 Jonathan Druart 2026-01-09 14:40:12 UTC
Created attachment 191079 [details] [review]
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt

See bug 41324 comment 6
1. Variable serialization
Comment 12 Jonathan Druart 2026-01-09 14:40:13 UTC
Created attachment 191080 [details] [review]
Bug 41563: acqui - auto tidy

Patch from commit d0220eb
Comment 13 Owen Leonard 2026-01-12 16:55:22 UTC
Created attachment 191290 [details] [review]
Bug 41563: Tidy kohaTable - acqui/acqui-home.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 14 Owen Leonard 2026-01-12 16:55:26 UTC
Created attachment 191291 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basket.tt

See bug 41324 comment 6
1. Variable serialization
3. "table_settings" variable

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 15 Owen Leonard 2026-01-12 16:55:29 UTC
Created attachment 191292 [details] [review]
Bug 41563: Tidy kohaTable - acqui/basketgroup.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 16 Owen Leonard 2026-01-12 16:55:33 UTC
Created attachment 191293 [details] [review]
Bug 41563: Tidy kohaTable - acqui/duplicate_orders.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 17 Owen Leonard 2026-01-12 16:55:36 UTC
Created attachment 191294 [details] [review]
Bug 41563: Tidy kohaTable - acqui/histsearch.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 18 Owen Leonard 2026-01-12 16:55:38 UTC
Created attachment 191295 [details] [review]
Bug 41563: Tidy kohaTable - acqui/invoice.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 19 Owen Leonard 2026-01-12 16:55:41 UTC
Created attachment 191296 [details] [review]
Bug 41563: Tidy kohaTable - acqui/lateorders.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 20 Owen Leonard 2026-01-12 16:55:44 UTC
Created attachment 191297 [details] [review]
Bug 41563: Tidy kohaTable - acqui/newordersuggestion.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 21 Owen Leonard 2026-01-12 16:55:47 UTC
Created attachment 191298 [details] [review]
Bug 41563: Tidy kohaTable - acqui/orderreceive.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs

We also removed 'UniqueItemFields' from the controller.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 22 Owen Leonard 2026-01-12 16:55:50 UTC
Created attachment 191299 [details] [review]
Bug 41563: Tidy kohaTable - acqui/parcel.tt

See bug 41324 comment 6
1. Variable serialization
2. Use of permissions and sysprefs

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 23 Owen Leonard 2026-01-12 16:55:53 UTC
Created attachment 191300 [details] [review]
Bug 41563: Tidy kohaTable - acqui/vendor_issues.tt

See bug 41324 comment 6
1. Variable serialization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 24 Owen Leonard 2026-01-12 16:55:56 UTC
Created attachment 191301 [details] [review]
Bug 41563: acqui - auto tidy

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 25 Owen Leonard 2026-01-12 16:55:59 UTC
Created attachment 191302 [details] [review]
Bug 41563: (follow-up) Fix two typos
Comment 26 Owen Leonard 2026-01-12 16:56:03 UTC
Created attachment 191303 [details] [review]
Bug 41563: (follow-up) Tidy parcel.tt