Bug 41565 - Tidy kohaTable block - bookings
Summary: Tidy kohaTable block - bookings
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 39715
Blocks: 41324 41812
  Show dependency treegraph
 
Reported: 2026-01-09 13:57 UTC by Jonathan Druart
Modified: 2026-02-17 13:48 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 41565: Tidy kohaTable - bookings/list.tt (4.82 KB, patch)
2026-01-09 14:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41565: bookings - auto tidy (26.91 KB, patch)
2026-01-09 14:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41565: Tidy kohaTable - bookings/list.tt (4.87 KB, patch)
2026-01-13 13:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41565: bookings - auto tidy (26.96 KB, patch)
2026-01-13 13:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41565: Tidy kohaTable - bookings/list.tt (4.93 KB, patch)
2026-02-09 12:22 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 41565: bookings - auto tidy (27.02 KB, patch)
2026-02-09 12:22 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2026-01-09 13:57:59 UTC

    
Comment 1 Jonathan Druart 2026-01-09 14:45:39 UTC
Created attachment 191101 [details] [review]
Bug 41565: Tidy kohaTable - bookings/list.tt

Patch from commit f70c7fe
Comment 2 Jonathan Druart 2026-01-09 14:45:40 UTC
Created attachment 191102 [details] [review]
Bug 41565: bookings - auto tidy

Patch from commit 9515333
Comment 3 Owen Leonard 2026-01-13 13:04:04 UTC
Created attachment 191347 [details] [review]
Bug 41565: Tidy kohaTable - bookings/list.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2026-01-13 13:04:07 UTC
Created attachment 191348 [details] [review]
Bug 41565: bookings - auto tidy

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Paul Derscheid 2026-02-09 12:22:07 UTC
Created attachment 192783 [details] [review]
Bug 41565: Tidy kohaTable - bookings/list.tt

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Paul Derscheid 2026-02-09 12:22:09 UTC
Created attachment 192784 [details] [review]
Bug 41565: bookings - auto tidy

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 7 Lucas Gass (lukeg) 2026-02-10 17:46:23 UTC
I think it is OK to ignore this:

xt/find-missing-csrf.t .......................... 1/3 
#   Failed test 'The <form> in the following files are missing it's corresponding csrf_token include (see bug 22990)'
#   at xt/find-missing-csrf.t line 39.
#          got: '1'
#     expected: '0'
# $VAR1 = 'koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt:415';
# Looks like you failed 1 test of 3.
Comment 8 Lucas Gass (lukeg) 2026-02-10 17:54:27 UTC
Nice work everyone!

Pushed to main for 26.05
Comment 9 Jonathan Druart 2026-02-10 19:52:02 UTC
(In reply to Lucas Gass (lukeg) from comment #7)
> I think it is OK to ignore this:
> 
> xt/find-missing-csrf.t .......................... 1/3 
> #   Failed test 'The <form> in the following files are missing it's
> corresponding csrf_token include (see bug 22990)'
> #   at xt/find-missing-csrf.t line 39.
> #          got: '1'
> #     expected: '0'
> # $VAR1 = 'koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt:415';
> # Looks like you failed 1 test of 3.

No it's not, I will have a look.
Comment 10 Jonathan Druart 2026-02-10 20:14:49 UTC
(In reply to Jonathan Druart from comment #9)
> (In reply to Lucas Gass (lukeg) from comment #7)
> > I think it is OK to ignore this:
> > 
> > xt/find-missing-csrf.t .......................... 1/3 
> > #   Failed test 'The <form> in the following files are missing it's
> > corresponding csrf_token include (see bug 22990)'
> > #   at xt/find-missing-csrf.t line 39.
> > #          got: '1'
> > #     expected: '0'
> > # $VAR1 = 'koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt:415';
> > # Looks like you failed 1 test of 3.
> 
> No it's not, I will have a look.

Opened bug 41812.