"Mark seen"/"Mark not seen" buttons on "Checkout notes" page don't do their error reporting correctly. This manifests itself as an error message "Unable to change status of note." showing up on the page when no error happens (and a page refresh confirms that the operation worked). This is caused by incorrect handling of an asynchronous JS response object, for which a patch is coming right up.
Created attachment 191406 [details] [review] Bug 41612: Await API responses when marking circulation notes as seen/not seen Test plan (specifics for KTD): 1. Enable checkout notes at /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=checkout+notes 2. Checkout a book at /cgi-bin/koha/circ/circulation.pl?findborrower=42, e.g. barcode 39999000011418 3. Navigate to OPAC, add a note to your checkout 4. Navigate to intranet's /cgi-bin/koha/circ/checkout-notes.pl 5. Try clicking Mark seen/Mark not seen, observe status not changing instantly and error messages popping up 6. Apply the patch 7. Observe the buttons working instantly and no error messsage showing up Sponsored-by: Steiermärkische Landesbibliothek