In the sysprefs BorrowerMandatoryField, BorrowerUnwantedField and the OPAC variations of each, the fields contactfirstname and contactname are labeled as: Alternate contact: First name (contactfirstname) Alternate contact: Surname (contactname) But the patron edit screen they are labeled as "Guarantor first name" and "Guarantor surname."
Created attachment 192321 [details] [review] Bug 41752: label concactfirstname and contactname as Guarantor first name and Guarantor surname This change impacts the display of patron fields listed in system preferences: BorrowerMandatoryField BorrowerUnwantedField PatronSelfModificationBorrowerUnwantedField PatronSelfRegistrationBorrowerMandatoryField PatronSelfRegistrationBorrowerUnwantedField To test: 1 - confirm that the sysprefs listed above include "Alternate contact: First name (contactfirstname)" and "Alternate contact: Surname (contactname)" 2 - confirm that toggling the display of these fields hides/shows the Guarantor first name and Guarantor surname fields in a patron record 3 - apply patch, restart_all 4 - confirm that sysprefs now show "Guarantor first name (contactfirstname)" and "Guarnator surname (contactname)" 5 - confirm toggling the display of these fields still hides/shows the correct fields in a patron record in the staff client, in self-ref, and in OPAC self-modification