Bug 41764 - ISSN hidden input missing from Z39.50 search form navigation
Summary: ISSN hidden input missing from Z39.50 search form navigation
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Andrew Fuerste-Henry
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-02-04 05:53 UTC by Red Shen
Modified: 2026-02-06 14:52 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: Sponsored
Comma delimited list of Sponsors: Athens County Public Libraries
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the Acquisitions and Cataloging Z39.50 search forms so that the pagination works when searching using the ISSN input field. When you click the next page of results, or got to a specific result page, the search now works as expected - it remembers the ISSN you were searching for, with "You searched for: ISSN: XXXX" shown above the search results, and search results shown. Previously, the ISSN was not remembered, and "Nothing found. Try another search." was shown, and no further search results were shown.
Version(s) released in:
Circulation function:


Attachments
Bug 41764: ISSN hidden input missing from Z39.50 search form navigation (3.39 KB, patch)
2026-02-04 17:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41764: ISSN hidden input missing from Z39.50 search form navigation (3.44 KB, patch)
2026-02-06 04:06 UTC, David Nind
Details | Diff | Splinter Review
Bug 41764: ISSN hidden input missing from Z39.50 search form navigation (3.50 KB, patch)
2026-02-06 14:52 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Red Shen 2026-02-04 05:53:58 UTC
Hello,

'issn' is missing in the following code field from 'z3950_search.tt':

                            <form method="post" action="z3950_search.pl" id="page_form" name="page_form" class="checkboxed">
                                [% INCLUDE 'csrf-token.inc' %]
                                <input type="hidden" name="op" id="op" value="cud-do_search" />
                                <input type="hidden" name="current_page" id="current_page" value="[% current_page | html %]" />
                                <input type="hidden" id="title"  name="title" value="[% title | html %]" />
                                <input type="hidden" id="isbn" name="isbn" value="[% isbn | html %]" />
                                <input type="hidden" id="lccall" name="lccall" value="[% lccall | html %]" />
                                <input type="hidden" id="controlnumber" name="controlnumber" value="[% controlnumber | html %]" />
                                <input type="hidden" id="srchany" name="srchany" value="[% srchany | html %]" />
                                <input type="hidden" id="author" name="author" value="[% author | html %]" />
                                <input type="hidden" id="publicationyear" name="publicationyear" value="[% publicationyear | html %]" />
                                <input type="hidden" id="subject" name="subject" value="[% subject | html %]" />
                                <input type="hidden" id="dewey" name="dewey" value="[% dewey | html %]" />
                                <input type="hidden" id="stdid" name="stdid" value="[% stdid | html %]" />
                                <input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
                                <input type="hidden" name="frameworkcode" value="[% frameworkcode | html %]" />
Comment 1 Owen Leonard 2026-02-04 17:45:40 UTC
Created attachment 192475 [details] [review]
Bug 41764: ISSN hidden input missing from Z39.50 search form navigation

This patch modifies the Acquisitions and Cataloging Z39.50 search forms
so that the pagination form includes a hidden ISSN input. This is
necessary for the form to submit the same search parameters each time
the user requests a new page of results.

To test, apply the patch and go to Acquisitions.

- Search for a vendor, and create a basket if necessary.
- Add to the basket and choose "From an external source."
- In the "ISSN" field, enter a partial ISSN number, e.g. 0361, and
  search.
- At the bottom of the search results, click the "Next page" button.
- The second page of results should load correctly. At the top of the
  table of results it should say "You searched for: ISSN: 0361"
- Perform the same test in Cataloging:
  - Cataloging -> New from Z39.50/SRU

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2026-02-06 04:06:02 UTC
Created attachment 192577 [details] [review]
Bug 41764: ISSN hidden input missing from Z39.50 search form navigation

This patch modifies the Acquisitions and Cataloging Z39.50 search forms
so that the pagination form includes a hidden ISSN input. This is
necessary for the form to submit the same search parameters each time
the user requests a new page of results.

To test, apply the patch and go to Acquisitions.

- Search for a vendor, and create a basket if necessary.
- Add to the basket and choose "From an external source."
- In the "ISSN" field, enter a partial ISSN number, e.g. 0361, and
  search.
- At the bottom of the search results, click the "Next page" button.
- The second page of results should load correctly. At the top of the
  table of results it should say "You searched for: ISSN: 0361"
- Perform the same test in Cataloging:
  - Cataloging -> New from Z39.50/SRU

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Andrew Fuerste-Henry 2026-02-06 14:52:12 UTC
Created attachment 192622 [details] [review]
Bug 41764: ISSN hidden input missing from Z39.50 search form navigation

This patch modifies the Acquisitions and Cataloging Z39.50 search forms
so that the pagination form includes a hidden ISSN input. This is
necessary for the form to submit the same search parameters each time
the user requests a new page of results.

To test, apply the patch and go to Acquisitions.

- Search for a vendor, and create a basket if necessary.
- Add to the basket and choose "From an external source."
- In the "ISSN" field, enter a partial ISSN number, e.g. 0361, and
  search.
- At the bottom of the search results, click the "Next page" button.
- The second page of results should load correctly. At the top of the
  table of results it should say "You searched for: ISSN: 0361"
- Perform the same test in Cataloging:
  - Cataloging -> New from Z39.50/SRU

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>