Bug 41788 - Make running the holds queue on click optional
Summary: Make running the holds queue on click optional
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 36455
Blocks:
  Show dependency treegraph
 
Reported: 2026-02-06 14:37 UTC by Donna
Modified: 2026-02-06 16:06 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch adds a system preference 'UseHoldsQueueFilterOptions'. When it is enabled it prevents the direct running of the holds queue by clicking on the 'Holds queue' links. With it enabled it will present the user with filter options before running the holds queue. This is to prevent excessive running of the holds queue which can cause slowdowns on larger systems.
Version(s) released in:
Circulation function:


Attachments
Bug 41788: Add system preference UseHoldsQueueFilterOptions (5.59 KB, patch)
2026-02-06 15:29 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 41788: Implement UseHoldsQueueFilterOptions (4.82 KB, patch)
2026-02-06 15:29 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Donna 2026-02-06 14:37:26 UTC
Pushing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36455 without an option to not use it has caused issues for libraries with large hold queues.  Without having the ability to filter before running the queue, it can take a long time to generate the list, taking up other resources on the server.  Once the queue finally renders, staff have to re-run the process with the limitations/filters in place.  This needs to be a system preference.
Comment 1 Lucas Gass (lukeg) 2026-02-06 15:29:27 UTC
Created attachment 192634 [details] [review]
Bug 41788: Add system preference UseHoldsQueueFilterOptions
Comment 2 Lucas Gass (lukeg) 2026-02-06 15:29:30 UTC
Created attachment 192635 [details] [review]
Bug 41788: Implement UseHoldsQueueFilterOptions

To test:
1. Apply patch, updatedatabase, restart_all
2. Search for new system preference UseHoldsQueueFilterOptions.
3. Disable it, and navigate to Circulation -> Holds queue
4. With the pref disabled the holds queue should run with asking for filters.
5. Also try the Holds queue link in the circ-nav ( left navigation ) panel, clicking it should automatically run the holds queue.
6. Also try the link in the breadcrumbs, clicking it should automatically run the holds queue.
7. Now enabled the pref.
8. With the pref enabled navigate to Circulation -> Holds queue, the holds queue link should present filters but NOT run the holds queue.
9. Test the Holds queue link in the circ-nav ( left navigation ) panel, click it should present filters but NOT run the holds queue.
10. Also try the link in the breadcrumbs, clicking them should presnt filters but not run the holds queue.
Comment 3 Jason Robb 2026-02-06 16:02:37 UTC
It looks like there may be some errors in the sysprefs.sql file at lines 491 and 581.

It might be good to add the phrase "filter options" to the syspref description to add some clarity: [Enable/Disable] filter options when running the holds queue.

Other than that it seems to work great!
Comment 4 Lucas Gass (lukeg) 2026-02-06 16:05:35 UTC
(In reply to Jason Robb from comment #3)
> It looks like there may be some errors in the sysprefs.sql file at lines 491
> and 581.
> 
> It might be good to add the phrase "filter options" to the syspref
> description to add some clarity: [Enable/Disable] filter options when
> running the holds queue.
> 
> Other than that it seems to work great!

What errors do you see?
Comment 5 Jason Robb 2026-02-06 16:06:42 UTC
	491	/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql('OPACAllowUserToChooseBranch','1',NULL,'Allow the user to choose the branch they want to pickup their hold from','YesNo'),

	581	('OpacShowRecentComments','0',NULL,'If ON a link to recent c/kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sqlomments will appear in the OPAC masthead','YesNo'),