Bug 41798 - Cannot enable 'passive' mode in File Transports for FTP
Summary: Cannot enable 'passive' mode in File Transports for FTP
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low critical
Assignee: Martin Renvoize (ashimema)
QA Contact: Paul Derscheid
URL:
Keywords:
Depends on: 39190
Blocks:
  Show dependency treegraph
 
Reported: 2026-02-09 11:49 UTC by Martin Renvoize (ashimema)
Modified: 2026-02-10 17:54 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: Unsponsored
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 41798: Fix FTP passive mode not saving and add display indicator (3.73 KB, patch)
2026-02-09 11:57 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 41798: Fix FTP passive mode not saving and add display indicator (3.78 KB, patch)
2026-02-10 16:16 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 41798: (QA follow-up) Add missing html filter (1.24 KB, patch)
2026-02-10 16:16 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2026-02-09 11:49:16 UTC
At some point in the (S)FTP transports bugs, we missed a patch that updated the controller to recognise 'passive' vs 'passiv' (i.e. the spelling fix)

This causes issues when trying to enable the passive mode which is recommended for FTP endpoints.
Comment 1 Martin Renvoize (ashimema) 2026-02-09 11:57:46 UTC
Created attachment 192743 [details] [review]
Bug 41798: Fix FTP passive mode not saving and add display indicator

The FTP passive mode setting was not being saved due to a typo in the
parameter name ('passiv' instead of 'passive'). This fixes the typo
and adds display of passive mode status in the transports table.

Test plan:
1. Go to Administration > File transports
2. Click "New file transport"
3. Fill in the name (e.g., "Test FTP")
4. Change Transport to "FTP"
5. Set Passive mode to "Enabled (Recommended)"
6. Fill in required fields (host, username, etc.) and save
7. Edit the transport you just created
8. Verify Passive mode is still set to "Enabled" (not reverted to Disabled)
9. Return to the file transports list
10. Verify the Transport column shows "FTP (passive)" for this transport
11. Edit the transport and change Passive mode to "Disabled"
12. Save and return to the list
13. Verify the Transport column now shows just "FTP" (without the passive indicator)

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 2 Martin Renvoize (ashimema) 2026-02-09 11:58:18 UTC
Tiny patch to a critical bug.. self SO and QA.
Comment 3 Paul Derscheid 2026-02-10 16:16:13 UTC
Created attachment 192912 [details] [review]
Bug 41798: Fix FTP passive mode not saving and add display indicator

The FTP passive mode setting was not being saved due to a typo in the
parameter name ('passiv' instead of 'passive'). This fixes the typo
and adds display of passive mode status in the transports table.

Test plan:
1. Go to Administration > File transports
2. Click "New file transport"
3. Fill in the name (e.g., "Test FTP")
4. Change Transport to "FTP"
5. Set Passive mode to "Enabled (Recommended)"
6. Fill in required fields (host, username, etc.) and save
7. Edit the transport you just created
8. Verify Passive mode is still set to "Enabled" (not reverted to Disabled)
9. Return to the file transports list
10. Verify the Transport column shows "FTP (passive)" for this transport
11. Edit the transport and change Passive mode to "Disabled"
12. Save and return to the list
13. Verify the Transport column now shows just "FTP" (without the passive indicator)

Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 4 Paul Derscheid 2026-02-10 16:16:16 UTC
Created attachment 192913 [details] [review]
Bug 41798: (QA follow-up) Add missing html filter

Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 5 Lucas Gass (lukeg) 2026-02-10 17:54:31 UTC
Nice work everyone!

Pushed to main for 26.05