ERM/Titles_spec.ts fails if run after ERM/Dialog_spec.ts because Dialog's "...created!" test create a package and does not delete it. 02:48:52 koha-1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did.
Created attachment 192999 [details] [review] Bug 41831: Mock POST /packages in Dialog_spec.ts ERM/Titles_spec.ts fails if run after ERM/Dialog_spec.ts because Dialog's "...created!" test create a package and does not delete it. 02:48:52 koha-1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did. Test plan: 0. Do not apply the patch 1. yarn cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts,t/cypress/integration/ERM/Titles_spec.ts => FAIL 2. Notice that one entry has been created in the DB table erm_eholdings_packages 3. Delete the DB entry: sudo koha-mysql kohadev -e 'DELETE FROM erm_eholdings_packages' 4. Apply this patch 5. Repeat 1 => SUCCESS 6. Notice that no new entry has been created in erm_eholdings_packages
Created attachment 193010 [details] [review] Bug 41831: Mock POST /packages in Dialog_spec.ts ERM/Titles_spec.ts fails if run after ERM/Dialog_spec.ts because Dialog's "...created!" test create a package and does not delete it. 02:48:52 koha-1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did. Test plan: 0. Do not apply the patch 1. yarn cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts,t/cypress/integration/ERM/Titles_spec.ts => FAIL 2. Notice that one entry has been created in the DB table erm_eholdings_packages 3. Delete the DB entry: sudo koha-mysql kohadev -e 'DELETE FROM erm_eholdings_packages' 4. Apply this patch 5. Repeat 1 => SUCCESS 6. Notice that no new entry has been created in erm_eholdings_packages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 193012 [details] [review] Bug 41831: Mock POST /packages in Dialog_spec.ts ERM/Titles_spec.ts fails if run after ERM/Dialog_spec.ts because Dialog's "...created!" test create a package and does not delete it. 02:48:52 koha-1 | <failure message="Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find content: 'There are no packages created yet' within the element: <fieldset#resources_relationship.rows> but never did. Test plan: 0. Do not apply the patch 1. yarn cypress run --spec t/cypress/integration/ERM/Dialog_spec.ts,t/cypress/integration/ERM/Titles_spec.ts => FAIL 2. Notice that one entry has been created in the DB table erm_eholdings_packages 3. Delete the DB entry: sudo koha-mysql kohadev -e 'DELETE FROM erm_eholdings_packages' 4. Apply this patch 5. Repeat 1 => SUCCESS 6. Notice that no new entry has been created in erm_eholdings_packages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to main for 26.05.00. Nice work all!