Created attachment 193003 [details] Wonky tag editor buttons To reproduce: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields.
It seems that css rule "display: block" for tag_editor behaves badly for serial Add item form. Removing it however breaks the buttons layout. And interestingly in biblios Add item form layout is displayed correctly.
I found the solution for this. In item modification, which has same structure, div element where Tag editor buttons are nested has class "subfield_line". And parent of this div element has class "item_edit_form". In addbiblio.css there is a rule: .item_edit_form .subfield_line { align-items: flex-start; display: flex; flex-basis: 100%; align-items: center; } We need to add same rule to serials-edit.pl to get Tag editor buttons to be inline with other elements of the div.
Created attachment 193717 [details] [review] Bug 41835: Add CSS file for serial edits page Add item forms Tag editor buttons on serial edits page were misaligned with their respective input fields. This happens because there is no rule for their parent div to display its children elements correctly. This patch adds this rule for serial edits page in new serial-edits.css file. To test: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields. 4. Apply this patch, restart services if needed. 5. Refresh page. -> Note that Tag editor buttons are now displayed inline with input fields. Sponsored-by: Koha-Suomi Oy
Created attachment 193718 [details] [review] Bug 41835: Add CSS file for serial edits page Add item forms Tag editor buttons on serial edits page were misaligned with their respective input fields. This happens because there is no rule for their parent div to display its children elements correctly. This patch adds this rule for serial edits page in new serial-edits.css file. To test: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields. 4. Apply this patch, restart services if needed. 5. Refresh page. -> Note that Tag editor buttons are now displayed inline with input fields.
Created attachment 193856 [details] [review] Bug 41835: Add CSS file for serial edits page Add item forms Tag editor buttons on serial edits page were misaligned with their respective input fields. This happens because there is no rule for their parent div to display its children elements correctly. This patch adds this rule for serial edits page in new serial-edits.css file. To test: 1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d). 2. Find an active serial subscription and receive items for it. 3. Open Add item form. -> Note that Tag editor buttons aren't displayed inline with input fields. 4. Apply this patch, restart services if needed. 5. Refresh page. -> Note that Tag editor buttons are now displayed inline with input fields. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 193857 [details] [review] Bug 41835: (follow-up) Clean up CSS There are some aspects of .subfield_line in addbiblio.css which are incorrect or redundant. This follow-up removes those lines from addbiblio.css and from the copied CSS in serials-edit.css