Bug 41835 - Add item forms Tag editor buttons on serial edition page are misaligned
Summary: Add item forms Tag editor buttons on serial edition page are misaligned
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Emmi Takkinen
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-02-12 11:05 UTC by Emmi Takkinen
Modified: 2026-02-25 15:06 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Wonky tag editor buttons (28.19 KB, image/png)
2026-02-12 11:05 UTC, Emmi Takkinen
Details
Bug 41835: Add CSS file for serial edits page (1.59 KB, patch)
2026-02-24 12:47 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 41835: Add CSS file for serial edits page (2.11 KB, patch)
2026-02-24 13:14 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 41835: Add CSS file for serial edits page (2.18 KB, patch)
2026-02-25 15:06 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41835: (follow-up) Clean up CSS (1.48 KB, patch)
2026-02-25 15:06 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2026-02-12 11:05:36 UTC
Created attachment 193003 [details]
Wonky tag editor buttons

To reproduce:
1. Make sure MARC framework for serials uses plugins in some 952 fields (e.g. dateaccessioned.pl plugin in field 952$d).
2. Find an active serial subscription and receive items for it.
3. Open Add item form.
-> Note that Tag editor buttons aren't displayed inline with input fields.
Comment 1 Emmi Takkinen 2026-02-12 11:26:57 UTC
It seems that css rule "display: block" for tag_editor behaves badly for serial Add item form. Removing it however breaks the buttons layout. And interestingly in biblios Add item form layout is displayed correctly.
Comment 2 Emmi Takkinen 2026-02-24 12:22:28 UTC
I found the solution for this. In item modification, which has same structure, div element where Tag editor buttons are nested has class "subfield_line". And parent of this div element has class "item_edit_form". In addbiblio.css there is a rule:

.item_edit_form .subfield_line {
    align-items: flex-start;
    display: flex;
    flex-basis: 100%;
    align-items: center;
}

We need to add same rule to serials-edit.pl to get Tag editor buttons to be inline with other elements of the div.
Comment 3 Emmi Takkinen 2026-02-24 12:47:29 UTC Comment hidden (obsolete)
Comment 4 Emmi Takkinen 2026-02-24 13:14:20 UTC
Created attachment 193718 [details] [review]
Bug 41835: Add CSS file for serial edits page

Add item forms Tag editor buttons on serial edits page were misaligned
with their respective input fields. This happens because there is no
rule for their parent div to display its children elements correctly.
This patch adds this rule for serial edits page in new serial-edits.css
file.

To test:
1. Make sure MARC framework for serials uses plugins in some 952 fields
(e.g. dateaccessioned.pl plugin in field 952$d).
2. Find an active serial subscription and receive items for it.
3. Open Add item form.
-> Note that Tag editor buttons aren't displayed inline with input fields.
4. Apply this patch, restart services if needed.
5. Refresh page.
-> Note that Tag editor buttons are now displayed inline with input fields.
Comment 5 Owen Leonard 2026-02-25 15:06:33 UTC
Created attachment 193856 [details] [review]
Bug 41835: Add CSS file for serial edits page

Add item forms Tag editor buttons on serial edits page were misaligned
with their respective input fields. This happens because there is no
rule for their parent div to display its children elements correctly.
This patch adds this rule for serial edits page in new serial-edits.css
file.

To test:
1. Make sure MARC framework for serials uses plugins in some 952 fields
   (e.g. dateaccessioned.pl plugin in field 952$d).
2. Find an active serial subscription and receive items for it.
3. Open Add item form.
   -> Note that Tag editor buttons aren't displayed inline with input
      fields.
4. Apply this patch, restart services if needed.
5. Refresh page.
   -> Note that Tag editor buttons are now displayed inline with input
      fields.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Owen Leonard 2026-02-25 15:06:35 UTC
Created attachment 193857 [details] [review]
Bug 41835: (follow-up) Clean up CSS

There are some aspects of .subfield_line in addbiblio.css which are
incorrect or redundant. This follow-up removes those lines from
addbiblio.css and from the copied CSS in serials-edit.css