Bug 41837 - Are we ready for rc1?
Summary: Are we ready for rc1?
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-02-12 14:29 UTC by Jonathan Druart
Modified: 2026-02-13 05:19 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41837: Remove $path from C4::Templates (1.49 KB, patch)
2026-02-12 14:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2026-02-12 14:29:01 UTC
Ready?

commit 571d609ccd443c17d9a96fc83d85493b4c4aff0f
Date:   Tue Dec 2 22:13:25 2003 +0000
    fix for bug 600

modified: C4/Output.pm
-my $path = C4::Context->config('includes') ||
-   "/usr/local/www/hdl/htdocs/includes";
+#FIXME: this is a quick fix to stop rc1 installing broken
+#Still trying to figure out the correct fix.
+my $path = C4::Context->config('intrahtdocs')."/intranet-tmpl/default/en/includes/";

This FIXME got moved to C4/Templates.pm:
commit 6b8be20497dd877c4ba5c5278a89fd82fc0862a9
Date:   Thu Aug 25 15:01:19 2011 +0200
    Bug 6755 Problems with switching languages


I think we are ready for "rc1" and we should remove this $path, that is actually not used in C4::Templates... sigh...
Comment 1 Jonathan Druart 2026-02-12 14:30:41 UTC
Created attachment 193011 [details] [review]
Bug 41837: Remove $path from C4::Templates

commit 571d609ccd443c17d9a96fc83d85493b4c4aff0f
Date:   Tue Dec 2 22:13:25 2003 +0000
    fix for bug 600

modified: C4/Output.pm
-my $path = C4::Context->config('includes') ||
-   "/usr/local/www/hdl/htdocs/includes";
+#FIXME: this is a quick fix to stop rc1 installing broken
+#Still trying to figure out the correct fix.
+my $path = C4::Context->config('intrahtdocs')."/intranet-tmpl/default/en/includes/";

This FIXME got moved to C4/Templates.pm:
commit 6b8be20497dd877c4ba5c5278a89fd82fc0862a9
Date:   Thu Aug 25 15:01:19 2011 +0200
    Bug 6755 Problems with switching languages

I think we are ready for "rc1" and we should remove this $path, that is actually not used in C4::Templates... sigh...