Changes made via the batch hold modification tool that are logged when made to holds individually from the bib are not logged when using the tool. To replicate: -Place a hold -Run the Holds log using the hold's reserve_id. There will be a single entry for the hold's creation. -Find the hold using the batch hold modification tool, and update its pickup location -Run the Holds log for that hold, and note that no entry has been generated for the changed pickup location -From the bib's Holds tab, update the same hold's pickup location -Run the Holds log again for that hold, and note that an entry was generated for the pickup location change when it was updated from the bib The same issue applies for updating expiration dates and for suspending/unsuspending, all of which do generate log entries when performed on individual holds from the bib.
Created attachment 193368 [details] [review] Bug 41883: logaction when batch modifying holds To test: -APPLY PATCH and restart_all -Place a hold -Run the Holds log using the hold's reserve_id. There will be a single entry for the hold's creation. -Find the hold using the batch hold modification tool, and update its pickup location -Look at the action log, the chnage should be logged -Try batch modding holds in other ways, ensure the changes are logged -Turn off HoldsLog and batch modify some holds, the changes should NOT be logged.
Created attachment 193374 [details] [review] Bug 41883: logaction when batch modifying holds To test: -APPLY PATCH and restart_all -Place a hold -Run the Holds log using the hold's reserve_id. There will be a single entry for the hold's creation. -Find the hold using the batch hold modification tool, and update its pickup location -Look at the action log, the chnage should be logged -Try batch modding holds in other ways, ensure the changes are logged -Turn off HoldsLog and batch modify some holds, the changes should NOT be logged. Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi>