Bug 41916 - SIP2 module cypress tests failing
Summary: SIP2 module cypress tests failing
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Paul Derscheid
URL:
Keywords:
Depends on: 37893
Blocks:
  Show dependency treegraph
 
Reported: 2026-02-24 15:34 UTC by Pedro Amorim
Modified: 2026-02-26 15:48 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
26.05.00
Version(s) released in:
Circulation function:


Attachments
Bug 41916: Clean-up obsolete code (2.05 KB, patch)
2026-02-24 15:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41916: Update Cypress tests (7.57 KB, patch)
2026-02-24 15:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41916: Clean-up obsolete code (2.11 KB, patch)
2026-02-24 15:56 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 41916: Update Cypress tests (7.62 KB, patch)
2026-02-24 15:57 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 41916: Clean-up obsolete code (2.17 KB, patch)
2026-02-25 15:33 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 41916: Update Cypress tests (7.68 KB, patch)
2026-02-25 15:33 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2026-02-24 15:34:41 UTC

    
Comment 1 Pedro Amorim 2026-02-24 15:38:34 UTC
Created attachment 193770 [details] [review]
Bug 41916: Clean-up obsolete code

No longer needed after bug 40191, but because both that and bug 37893 went in close to each other, this remained.
Removing this fixes the toolbar buttons on the SIP2 account form and fixes the console warning that was causing a failure in cypress tests
Comment 2 Pedro Amorim 2026-02-24 15:38:36 UTC
Created attachment 193771 [details] [review]
Bug 41916: Update Cypress tests

Button is now 'Save' not 'Submit' after bug 40191

On ktd:
cypress run --spec t/cypress/integration/SIP2/*

All tests must pass
Comment 3 Lucas Gass (lukeg) 2026-02-24 15:56:58 UTC
Created attachment 193772 [details] [review]
Bug 41916: Clean-up obsolete code

No longer needed after bug 40191, but because both that and bug 37893 went in close to each other, this remained.
Removing this fixes the toolbar buttons on the SIP2 account form and fixes the console warning that was causing a failure in cypress tests

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2026-02-24 15:57:01 UTC
Created attachment 193773 [details] [review]
Bug 41916: Update Cypress tests

Button is now 'Save' not 'Submit' after bug 40191

On ktd:
cypress run --spec t/cypress/integration/SIP2/*

All tests must pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Paul Derscheid 2026-02-25 15:33:49 UTC
Created attachment 193906 [details] [review]
Bug 41916: Clean-up obsolete code

No longer needed after bug 40191, but because both that and bug 37893 went in close to each other, this remained.
Removing this fixes the toolbar buttons on the SIP2 account form and fixes the console warning that was causing a failure in cypress tests

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 6 Paul Derscheid 2026-02-25 15:33:51 UTC
Created attachment 193907 [details] [review]
Bug 41916: Update Cypress tests

Button is now 'Save' not 'Submit' after bug 40191

On ktd:
cypress run --spec t/cypress/integration/SIP2/*

All tests must pass

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 7 Lucas Gass (lukeg) 2026-02-25 15:48:24 UTC
Pushed to main for 26.05.00