Bug 41942 - Hiding primary contact method hides lang with PatronSelfModificationBorrowerUnwantedField
Summary: Hiding primary contact method hides lang with PatronSelfModificationBorrowerU...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on: 34438
Blocks:
  Show dependency treegraph
 
Reported: 2026-02-26 09:42 UTC by Fridolin Somers
Modified: 2026-02-26 12:43 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41942: Fix lang hidding in opac patron modification (9.46 KB, patch)
2026-02-26 10:10 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 41942: Fix lang hidding in opac patron modification (9.52 KB, patch)
2026-02-26 12:43 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2026-02-26 09:42:05 UTC
Bug 34438 added lang in opac registration/modification form.
But it is linked to primary contact method hidden or not.

Looks like this is not on purpose.
Comment 1 Fridolin Somers 2026-02-26 10:10:53 UTC
Created attachment 193976 [details] [review]
Bug 41942: Fix lang hidding in opac patron modification

Bug 34438 added lang in opac registration/modification form.
But it is linked to primary contact method hidden or not.

Looks like this is not on purpose.
This patch removes this link.

Test plan:
1) Verify system preference 'PatronSelfModificationBorrowerUnwantedField' is empty
2) Go to OPAC user account > Personal details
3) You see 'Preferred language for notices'
4) In system preference 'PatronSelfModificationBorrowerUnwantedField' check 'primary_contact_method'
5) Go to OPAC user account > Personal details
=> Without patch lang is also hidden
=> With patch lang is not hidden
Comment 2 Owen Leonard 2026-02-26 12:43:14 UTC
Created attachment 193982 [details] [review]
Bug 41942: Fix lang hidding in opac patron modification

Bug 34438 added lang in opac registration/modification form.
But it is linked to primary contact method hidden or not.

Looks like this is not on purpose.
This patch removes this link.

Test plan:
1) Verify system preference
   'PatronSelfModificationBorrowerUnwantedField' is empty
2) Go to OPAC user account > Personal details
3) You see 'Preferred language for notices'
4) In system preference 'PatronSelfModificationBorrowerUnwantedField'
   check 'primary_contact_method'
5) Go to OPAC user account > Personal details
   => Without patch lang is also hidden
   => With patch lang is not hidden

Signed-off-by: Owen Leonard <oleonard@myacpl.org>