The PA_CLASS description shows on opac-memberentry.pl but the code doesn't show in the fieldset ID. This leads to each fieldset having the same ID of "aai_".
Created attachment 194369 [details] [review] Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML!
Created attachment 194370 [details] [review] Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 194371 [details] [review] Bug 41970: Fix typo in pa_class in template This change fixes a typo from pa_loo to pa_class, so that the ID attribute of the fieldset is properly set when using PA_CLASS to group patron attributes. Test plan: 0. Set up two PA_CLASS values 1. Set up two patron attributes which are viewable/editable on the OPAC and assign them one class each 2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 3. Look at the HTML and note that fieldsets for both PA classes have the ID of "aai_" 4. Apply the patch 5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl 6. Note that now the fieldsets have ID attributes of "aai_<PA_CLASS code>". 7. Rejoice as now it's easier to use Javascript and CSS and have valid HTML! Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>