Bug 41970 - PA_CLASS does not show in fieldset ID on opac-memberentry.pl
Summary: PA_CLASS does not show in fieldset ID on opac-memberentry.pl
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: David Cook
QA Contact: Jonathan Druart
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2026-03-03 01:30 UTC by David Cook
Modified: 2026-03-03 07:51 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41970: Fix typo in pa_class in template (1.97 KB, patch)
2026-03-03 01:38 UTC, David Cook
Details | Diff | Splinter Review
Bug 41970: Fix typo in pa_class in template (2.02 KB, patch)
2026-03-03 06:36 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 41970: Fix typo in pa_class in template (2.10 KB, patch)
2026-03-03 07:51 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2026-03-03 01:30:48 UTC
The PA_CLASS description shows on opac-memberentry.pl but the code doesn't show in the fieldset ID. This leads to each fieldset having the same ID of "aai_".
Comment 1 David Cook 2026-03-03 01:38:55 UTC
Created attachment 194369 [details] [review]
Bug 41970: Fix typo in pa_class in template

This change fixes a typo from pa_loo to pa_class, so that
the ID attribute of the fieldset is properly set when using PA_CLASS
to group patron attributes.

Test plan:
0. Set up two PA_CLASS values
1. Set up two patron attributes which are viewable/editable on the
OPAC and assign them one class each
2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl
3. Look at the HTML and note that fieldsets for both PA classes
have the ID of "aai_"

4. Apply the patch

5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl
6. Note that now the fieldsets have ID attributes of
"aai_<PA_CLASS code>".
7. Rejoice as now it's easier to use Javascript and CSS and have valid
HTML!
Comment 2 Roman Dolny 2026-03-03 06:36:47 UTC
Created attachment 194370 [details] [review]
Bug 41970: Fix typo in pa_class in template

This change fixes a typo from pa_loo to pa_class, so that
the ID attribute of the fieldset is properly set when using PA_CLASS
to group patron attributes.

Test plan:
0. Set up two PA_CLASS values
1. Set up two patron attributes which are viewable/editable on the
OPAC and assign them one class each
2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl
3. Look at the HTML and note that fieldsets for both PA classes
have the ID of "aai_"

4. Apply the patch

5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl
6. Note that now the fieldsets have ID attributes of
"aai_<PA_CLASS code>".
7. Rejoice as now it's easier to use Javascript and CSS and have valid
HTML!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Jonathan Druart 2026-03-03 07:51:03 UTC
Created attachment 194371 [details] [review]
Bug 41970: Fix typo in pa_class in template

This change fixes a typo from pa_loo to pa_class, so that
the ID attribute of the fieldset is properly set when using PA_CLASS
to group patron attributes.

Test plan:
0. Set up two PA_CLASS values
1. Set up two patron attributes which are viewable/editable on the
OPAC and assign them one class each
2. Go to http://localhost:8080/cgi-bin/koha/opac-memberentry.pl
3. Look at the HTML and note that fieldsets for both PA classes
have the ID of "aai_"

4. Apply the patch

5. Reload the page http://localhost:8080/cgi-bin/koha/opac-memberentry.pl
6. Note that now the fieldsets have ID attributes of
"aai_<PA_CLASS code>".
7. Rejoice as now it's easier to use Javascript and CSS and have valid
HTML!

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>