Bug 28633 added "First name:" to the "Contact information" on moremember.pl when there's a firstname and preferred name. (This has a number of issues when migrating patrons with non-Koha tools, but I'll put a pin in that for now.) Because people got confused why only "First name:" was appearing, bug 39587 added the "Surname:" as well (one day, I hope we can change this to "Last name:" which is more optimal for UX but oh well). At this point, we should add "Preferred name:" (if it differs from First name - see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633#c144), and "Middle name:". This should provide maximum clarity about which name is which.
Created attachment 194417 [details] [review] Bug 41986: Add more names to Contact information and clarify preferred name This patch adds the "Middle name" to the Contact information on moremember.pl, and it adds "Preferred name:" when it differs from the "First name:". This provides maximum clarity to staff users. Test plan: 0. Apply the patch 1. Go to the "Patrons" module and search for or add a new patron 2. Add a firstname, a middle name, and a surname. Also add a "Preferred name" which matches the firstname. 3. Go to "Details" on the sidebar, and note that "First name", "Middle name", and "Surname" appear in the "Contact information". 4. Edit the patron and change "Preferred name" to a name that does not match the "First name" 5. Go to "Details" on the sidebar, and note that "Preferred name" now shows as well. 6. Enjoy fully comprehending which name is which for the patron!
People can debate whether this is a bug fix or an enhancement. I think an argument could be made for either. I marked it as a bug fix because I think it fixes a problem rather than adding an improvement per se.
Created attachment 194419 [details] [review] Bug 41986: Add more names to Contact information and clarify preferred name This patch adds the "Middle name" to the Contact information on moremember.pl, and it adds "Preferred name:" when it differs from the "First name:". This provides maximum clarity to staff users. Test plan: 0. Apply the patch 1. Go to the "Patrons" module and search for or add a new patron 2. Add a firstname, a middle name, and a surname. Also add a "Preferred name" which matches the firstname. 3. Go to "Details" on the sidebar, and note that "First name", "Middle name", and "Surname" appear in the "Contact information". 4. Edit the patron and change "Preferred name" to a name that does not match the "First name" 5. Go to "Details" on the sidebar, and note that "Preferred name" now shows as well. 6. Enjoy fully comprehending which name is which for the patron! Signed-off-by: David Nind <david@davidnind.com>
You're an absolute legend, David Nind. Thanks heaps!
Created attachment 194434 [details] [review] Bug 41986: Add more names to Contact information and clarify preferred name This patch adds the "Middle name" to the Contact information on moremember.pl, and it adds "Preferred name:" when it differs from the "First name:". This provides maximum clarity to staff users. Test plan: 0. Apply the patch 1. Go to the "Patrons" module and search for or add a new patron 2. Add a firstname, a middle name, and a surname. Also add a "Preferred name" which matches the firstname. 3. Go to "Details" on the sidebar, and note that "First name", "Middle name", and "Surname" appear in the "Contact information". 4. Edit the patron and change "Preferred name" to a name that does not match the "First name" 5. Go to "Details" on the sidebar, and note that "Preferred name" now shows as well. 6. Enjoy fully comprehending which name is which for the patron! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>