The Patron column on the checkout history tab of a bib (/cgi-bin/koha/catalogue/issuehistory.pl) isn't showing up properly due to a typo in a permission check in the template file. It should be checking "CAN_user_circulate_circulate_remaining_permissions" but instead has "CAN_user_circulate_remaining_permissions"
Created attachment 195101 [details] [review] Bug 42062: correct permissions check in template file To test: 1 - have a biblio with circulation history 2 - confirm syspref intranetreadinghistory is enabled and you're logged in as a user with permissions view_checkout_history and circulate_remaining_permissions (or superlibrarian or top-level borrowers and circulation permissions) 3 - load the checkout history page on your biblio record 4 - confirm there is no Patron column and that column is not hidden via column config 5 - apply patch, restart services, reload page 6 - confirm Patron column is present
Created attachment 195120 [details] [review] Bug 42062: correct permissions check in template file To test: 1 - have a biblio with circulation history 2 - confirm syspref intranetreadinghistory is enabled and you're logged in as a user with permissions view_checkout_history and circulate_remaining_permissions (or superlibrarian or top-level borrowers and circulation permissions) 3 - load the checkout history page on your biblio record 4 - confirm there is no Patron column and that column is not hidden via column config 5 - apply patch, restart services, reload page 6 - confirm Patron column is present Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Tested : - permission catalogue => column is not there - permissions catalogue + circulate_remaining_permissions => column is not there - permissions catalogue + circulate_remaining_permissions + view_checkout_history => column is there - superlibrarian => column is there Signed \o/