Bug 4439 - two acq webservices should use C4::Service
Summary: two acq webservices should use C4::Service
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Hugh Davenport
QA Contact: Bugs List
URL:
Keywords:
: 9411 (view as bug list)
Depends on: 9412
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-03 04:23 UTC by Galen Charlton
Modified: 2018-06-28 18:34 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
bug 4439 Change some helper files to use C4::Service (6.87 KB, patch)
2013-01-17 05:20 UTC, Hugh Davenport
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:27:11 UTC


---- Reported by gmcharlt@gmail.com 2010-05-03 16:23:07 ----

To be consistent with previously-defined web services, admin/check_budget_parent.pl and admin/check_parent_total.pl should use C4::Service instead of hand-written code and ./koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ajax.tmpl.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC  ---

This bug was previously known as _bug_ 4439 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4439

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Hugh Davenport 2013-01-17 05:20:50 UTC
Created attachment 14653 [details] [review]
bug 4439 Change some helper files to use C4::Service

Depends on bug 4437 to avoid conflicts

Depends on bug 9412 for a new feature used

Also fixes bug 9411

Signed-off-by: Hugh Davenport <hugh@davenport.net.nz>
Comment 2 Owen Leonard 2013-03-19 09:50:30 UTC
This patch needs a test plan.
Comment 3 Hugh Davenport 2013-07-05 21:13:00 UTC
Hey Owen,

What would the format of a test plan be?

Cheers,

Hugh
Comment 4 Marc Véron 2016-08-22 08:38:11 UTC
Still valid?
Comment 5 Jonathan Druart 2018-06-28 18:34:43 UTC
*** Bug 9411 has been marked as a duplicate of this bug. ***