---- Reported by firstname.lastname@example.org 2010-05-12 21:16:29 ----
Created an attachment
/cgi-bin/koha/suggestion/suggestion.pl contains some not translated strings:
Tab headings 'Pending (x)', 'Accepted (x)'... are not translatable.
Choose a reason > Others > 'please note your reason here' is not translatable.
Not sure how to fix this, help or patch welcome :)
--- Bug imported by email@example.com 2010-05-21 01:27 UTC ---
This bug was previously known as _bug_ 4497 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4497
Imported an attachment (id=2130)
Unknown operating system Windows NT. Setting to default OS "All".
Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
This bug either had no qa contact or an invalid one.
The original submitter of attachment 2130 [details] is unknown.
Reassigning to the person who moved it here: firstname.lastname@example.org.
The first problem arises from the fact that the headings are coming straight from the database where they're stored as English strings. The script does "ucfirst(lc( $criteriumvalue))" on the database values ("ACCEPTED," etc).
The second problem I don't understand. The string comes from this markup in the template:
<input type="text" size="31" id="select-other_reason<!-- TMPL_VAR NAME="suggestiontype" -->" name="other_reason<!-- TMPL_VAR NAME="suggestiontype" -->" value="please note your reason here..." />
Why wouldn't the <input>'s value attribute be translated like any other?
Problem still existing in master.
Created attachment 4646 [details] [review]
Bug 4497: Make tabs for managing suggestions translatable
This patch makes the tabs on the manage suggestion page translatable.
- Create some suggestions in intranet or opac and manage them to make the
different status tabs appear: accecpted, pending, checked, rejected
- Apply patch, run 'perl translate update <languagecode>'
- Check po file for string '%s %sPending %sAccepted %sChecked %sRejected %sAvailable %sOrdered%s %s%s %sNo name%s (%s)'
- Translate it, save and run 'perl translate install <languagecode>'
Tabs should now appear translated.
Created attachment 4658 [details] [review]
I didn't do the whole translation procedure to test this patch, but it's a simple and straightforward template change that clearly addresses the issue.
It still feels "wrong" to be storing English strings in the database and using template logic to evaluate them, but this patch solves the practical problem.
Template changes, effecting translations, please test