* pdf invoice says “ publié par” instead of “published by” * pdf invoice says degree symbol instead of # (as does the basket grouping) * pdf invoice says GST instead of tax rate * pdf not translatable
Created attachment 2372 [details] orderlines
Created attachment 2373 [details] ordersummary
Created attachment 2374 [details] headers
(In reply to Nicole C. Engard from comment #0) > * pdf invoice says “ publié par” instead of “published by” This has been fixed. > * pdf invoice says degree symbol instead of # (as does the basket > grouping) This could be corrected by modifying the .odt files in koha-tmpl/intranet-tmpl/prog/pdf > * pdf invoice says GST instead of tax rate Where does one generate a PDF of an invoice? > * pdf not translatable I don't know if this bug predates the introduction of the OrderPdfFormat preference... It's better than nothing but only expands the options to English, French, and German. Why don't we simply generate a printable view and let the user save as/print to a PDF?
Created attachment 95759 [details] [review] Bug 5016: Fix some translation issues with English PDF order templates Changes made: - Instead of n° print no. - Market Identification => Market identification - GST => Tax To test: - Create at least 2 baskets with one or more orders - Create a basket group with those baskets - Print the PDF using - the 2 page layout - the 3 page layout - Verify that the changes made appear and everything looks correct
> I don't know if this bug predates the introduction of the OrderPdfFormat > preference... It's better than nothing but only expands the options to > English, French, and German. Why don't we simply generate a printable view > and let the user save as/print to a PDF? Yes, that would be nice!
Created attachment 98807 [details] [review] Bug 5016: Fix some translation issues with English PDF order templates Changes made: - Instead of n° print no. - Market Identification => Market identification - GST => Tax To test: - Create at least 2 baskets with one or more orders - Create a basket group with those baskets - Print the PDF using (change using OrderPdfFormat system preference): - the 2 page layout - the 3 page layout - Verify that the changes made appear and everything looks correct Signed-off-by: David Nind <david@davidnind.com>
Thx David, almost forgot about this one!
% git show master:koha-tmpl/intranet-tmpl/prog/pdf/layout2pages.odt > /tmp/layout2pages_master.odt % git show BZ5016:koha-tmpl/intranet-tmpl/prog/pdf/layout2pages.odt > /tmp/layout2pages_5016.odt % odt2txt /tmp/layout2pages_master.odt % odt2txt /tmp/layout2pages_5016.odt % diff /tmp/layout2pages_master.txt /tmp/layout2pages_5016.txt 7c7 < Order form N° on --- > Order form no. on 12c12 < Market Identification --- > Market identification % git show master:koha-tmpl/intranet-tmpl/prog/pdf/layout3pages.odt > /tmp/layout3pages_master.odt % git show BZ5016:koha-tmpl/intranet-tmpl/prog/pdf/layout3pages.odt > /tmp/layout3pages_5016.odt % odt2txt /tmp/layout3pages_master.odt % odt2txt /tmp/layout3pages_5016.odt % diff /tmp/layout3pages_master.txt /tmp/layout3pages_5016.txt 7c7 < Order form N° on --- > Order form no. on 12c12 < Market Identification --- > Market identification 59c59 < ORDER REFERENCES FOR ORDER FORM N° --- > ORDER REFERENCES FOR ORDER FORM NO.
Created attachment 99190 [details] [review] Bug 5016: Fix some translation issues with English PDF order templates Changes made: - Instead of n° print no. - Market Identification => Market identification - GST => Tax To test: - Create at least 2 baskets with one or more orders - Create a basket group with those baskets - Print the PDF using - the 2 page layout - the 3 page layout - Verify that the changes made appear and everything looks correct Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to master for 20.05
Pushed to 19.11.x branch for 19.11.04