Bug 5138 - Erroneous display for OPACShelfBrowser with GoogleJackets enabled
Summary: Erroneous display for OPACShelfBrowser with GoogleJackets enabled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: rel_3_0
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-15 07:35 UTC by Indranil Das Gupta
Modified: 2012-10-25 23:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of the error (56.68 KB, image/jpeg)
2010-08-15 07:35 UTC, Indranil Das Gupta
Details
Proposed fix for 3.0.x (14.62 KB, patch)
2010-08-16 15:00 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Indranil Das Gupta 2010-08-15 07:35:13 UTC
Created attachment 2523 [details]
Screenshot of the error

Issue faced on Koha 3.00.06.010 running on Ubuntu 10.04 (32-bit)

On enabling GoogleJackets pref under Enriched content, the OPAC shelf browser option is throwing up the same book cover for all the items on shelf. 

The html output source under error condition can be seen here http://pastebin.ca/1917241. 

Looks to me it is similiar to this earlier post - http://old.nabble.com/Koha-3.0.5-%2B-%22Browse-Shelf%22-issue-td27693200.html
Comment 1 Owen Leonard 2010-08-16 15:00:33 UTC
Created attachment 2524 [details] [review]
Proposed fix for 3.0.x

- Copying a couple of changes from HEAD so that the browser uses
  the browser titles' isbns instead of the page title's isbn. This correction 
  should fix all book cover image providers, not just Google
- Correcting system preference check in the template:
  OPACAmazonEnabled instead of AmazonEnabled
Comment 2 Indranil Das Gupta 2010-08-16 20:01:42 UTC
(In reply to comment #1)
> Created attachment 2524 [details] [review]
> Proposed fix for 3.0.x
> 
> - Copying a couple of changes from HEAD so that the browser uses
>   the browser titles' isbns instead of the page title's isbn. This correction 
>   should fix all book cover image providers, not just Google
> - Correcting system preference check in the template:
>   OPACAmazonEnabled instead of AmazonEnabled

the patch is working nicely!
Comment 3 Chris Cormack 2010-12-14 01:31:10 UTC
This is just for 3.0.x? Henri Damien has this been pushed?
Comment 4 claire.hernandez@biblibre.com 2011-04-06 08:09:13 UTC
I am not yet completly sure but for me, master does not need it. In master code, I found browser_normalized_isbn and OPACAmazonEnabled for example.