Created attachment 2789 [details] [review]
Patch for JSON bug
After updating jQuery in version 1.4.3, I could not import MARC records with the tools "Stage MARC records for import".
Indeed, JSON was malformed, the JSON script did not respect the standard. So I changed all JSON scripts created on Koha.
Please note, this problem is a blocker with jQuery 1.4.x but not with 1.3.x as the old version was more permissive.
Après avoir mis à jour jQuery en version 1.4.3, je ne pouvais plus importer de notices MARC avec l'outils "Stage MARC records for import". En effet, les JSON étaient mal formés, ils ne respectaient pas la norme. J'ai donc modifié tous les script créant des JSON sur Koha.
Attention, ce problème est bloquant avec jQuery 1.4.x mais pas 1.3.x car l'ancienne version était plus permissive.
Ci-joint, le correctif
Can you give more details about problem you encountered? I'm working on a branch which includes an upgraded jquery (1.4.4) and I was able to import MARC records without any problem.
Could it be a problem with jquery 1.4.3?
I should also note that my branch is based on HEAD, not rel_3_2.
Tested on branch 3.2.x with jQuery 1.4.3
I successfully reproduce the bug and the patch solve the problem.
Owen, can you please test this patch and check it works with 1.4.4 too. If so, ill push it as it fixes it for 1.4.3 without breaking 1.4.4.
> Owen, can you please test this patch and check it works with 1.4.4 too.
Can I get some additional information on how to test this? What is broken when it doesn't work?
This bug is mentioned in:
Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x http://lists.koha-community.org/pipermail/koha-patches/2011-March/014028.html
I am resetting the patch status from "Patch pushed" to "Signed off" because the branch new/bug_5449 still needs to be merged into master. I tested and can confirm that it merges cleanly.
It is in master now, please test