When you're in the staff client if an item has a not for loan reason of 'not for loan' you see "Not for Loan (Not for Loan)" in the status. In the OPAC you just see the reason or the value, can we do that in the staff client?
The template displays "Not for loan" by default, followed by the actual text of the not for loan authorized value. In the staff client that text is from the 'lib' column: +------------------+------------------+-----------------------+ | authorised_value | lib | lib_opac | +------------------+------------------+-----------------------+ | -1 | Ordered | OPAC Ordered | | 1 | Not for Loan | OPAC Not for Loan | +------------------+------------------+-----------------------+ I agree that "Not for Loan (Not for Loan)" is redundant, but since the text in parentheses is editable by the library, perhaps it should be left up to them to change it to something which clarifies their own definition of "Not for loan?"
Hm, it might also make sense to keep the hardcoded "Not for loan" because it's translatable. So even when someone doesn't know that the text in () means, there will still be some useful information.