Bug 5838 - Don't show sql statement on guided reports result page
Summary: Don't show sql statement on guided reports result page
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Bugs List
URL: /cgi-bin/koha/reports/guided_reports....
Depends on:
Reported: 2011-03-07 07:06 UTC by Katrin Fischer
Modified: 2012-10-25 23:03 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

proposed patch (1.23 KB, patch)
2011-03-07 07:08 UTC, Katrin Fischer
Details | Diff | Splinter Review
screenshot (29.41 KB, image/png)
2011-03-27 17:05 UTC, Katrin Fischer
New patch (1.64 KB, patch)
2011-03-27 17:09 UTC, Katrin Fischer
Details | Diff | Splinter Review
Signed-off patch (1.71 KB, patch)
2011-03-27 17:31 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2011-03-07 07:06:38 UTC
The sql statement is shown unformatted under the notes and result numbers of a guided report. As we have a page dedicated to show the sql of a guided report, I don't think this is necessary.
Comment 1 Katrin Fischer 2011-03-07 07:08:13 UTC Comment hidden (obsolete)
Comment 2 Paul Poulain 2011-03-07 08:19:38 UTC
Not sure I agree with this idea. I find handfull to have the details of the report in case of printing it.
(won't argue for hours if others say "yes it's a good idea" though)
Comment 3 Katrin Fischer 2011-03-07 08:27:59 UTC
Hi Paul, I disagree :)

I especially don't like it on printouts. My librarians have no idea about the sql behind the reporst and are more confused by it than that it is helpful for them. Also you might want to hang up some of your printed reports in the library.

The sql output currently is not formatted in any way, not wrapped into a html tag even and flowing together with the pagination. Making the pagination hard to be seen. And longer sql statements quite unreadable.
Comment 4 Nicole C. Engard 2011-03-07 19:29:30 UTC
Can I have a link to a page that shows the way this used to appear? I'm confused about how to test this because I'm not sure what page to look at.
Comment 5 Katrin Fischer 2011-03-07 21:22:12 UTC
Hi Nicole, thx for testing :)

1) Create a new report from sql
2) Run it
3) Look at the top of the results page

URL will be something like '/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run this report'.
Comment 6 Katrin Fischer 2011-03-27 17:05:43 UTC
Created attachment 3442 [details]

New suggestion: wrapping the sql output in <pre> with unique id.

- sql can be formatted 
- sql can be hidden using css and the unique id
- pagination is pushed to its own line and better visible
Comment 7 Katrin Fischer 2011-03-27 17:09:03 UTC
Created attachment 3443 [details] [review]
New patch
Comment 8 Jared Camins-Esakov 2011-03-27 17:31:53 UTC
Created attachment 3445 [details] [review]
Signed-off patch
Comment 9 Chris Cormack 2011-03-28 20:56:37 UTC
I like this new patch much better, pushed, please test
Comment 10 MJ Ray (software.coop) 2011-04-10 11:25:00 UTC
This bug is mentioned in:
Bug 5838: Don't show sql statement on guided	reports result page http://lists.koha-community.org/pipermail/koha-patches/2011-March/013998.html
Bug 5838: Don't show sql	statement on guided reports result page http://lists.koha-community.org/pipermail/koha-patches/2011-March/014007.html
Bug 5838: Format sql outout on guided reports http://lists.koha-community.org/pipermail/koha-patches/2011-March/014240.html
Bug 5838: Format sql outout on guided reports http://lists.koha-community.org/pipermail/koha-patches/2011-March/014241.html