The tabs Normal View, MARC and ISBD are shown below the title in OPAC normal view. For MARC and ISBD view the name of the view is added to the left of the tabs.
This proposed patch puts the three tabs at the same position for Normal, MARC and ISBD view. The text of the current view is made bold; additional titles for MARC/ISBD are not needed anymore and thus removed.
A few hardcoded styles have been moved from the template to opac.css allowing improved customization.
Please test all three views
1) with OPACXSLTDetailsDisplay enabled
[MARC View: Test also "View plain" here]
2) with OPACXSLTDetailsDisplay disabled.
Created attachment 3280 [details] [review]
Created attachment 3286 [details]
normal view like it is now
Created attachment 3287 [details]
normal view after patch
Signing-off on this, it works like described.
I like the new display, it seems more consistent and a bit cleaner to me. Not sure if this is the majority opinion though.
Pushed, please test and mark resolved
Works for me. Anyone else to close it?
Created attachment 3292 [details]
On Normal view I see the tabs twice (see screenshot).
Marc/Plain/ISBD views display well.
I notice that the tabs are not the same.
Are you using a custom xslt stylesheet?
The stylesheet for MARC21 opac details was adjusted in the patch. Is it possible that these views are still in your Unimarc xslt file?
I see that lines 55 up to 69 still contain the views in a div tag in the UNIMARCslim2OPACDetail.xsl in koha-tmpl/opac-tmpl/prog/en/xslt.
Could you please test removing them?
(In reply to comment #10)
> I see that lines 55 up to 69 still contain the views in a div tag in the
> UNIMARCslim2OPACDetail.xsl in koha-tmpl/opac-tmpl/prog/en/xslt.
> Could you please test removing them?
That's it! Preparing a patch for Unimarc stylesheet...
Created attachment 3321 [details] [review]
Patch for Unimarc stylesheet
Follow up patch for UNIMARC pushed, please test
This bug is mentioned in:
Bug 5848: Same position for the tabs of Normal, MARC and ISBD view in opac detail http://lists.koha-community.org/pipermail/koha-patches/2011-March/014035.html
Bug 5848: Remove duplicated tabs in opac details for Unimarc http://lists.koha-community.org/pipermail/koha-patches/2011-March/014079.html
Bug 5848: Remove duplicated tabs in opac details for Unimarc http://lists.koha-community.org/pipermail/koha-patches/2011-March/014100.html