Bug 5875 - waitingreserves highlighting now depends on maxpickupdate
Summary: waitingreserves highlighting now depends on maxpickupdate
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.4
Hardware: All All
: P1 - high enhancement
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on: 5872
Blocks:
  Show dependency tree / graph
 
Reported: 2011-03-16 01:52 UTC by Chris Cormack
Modified: 2012-10-26 00:51 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed Patch (7.01 KB, patch)
2011-03-16 02:01 UTC, Chris Cormack 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-03-16 01:52:22 UTC 

    


    


      



        
          Comment 1
        

        
          Chris Cormack

        

        
        

        
          2011-03-16 02:01:36 UTC
        

      






Created attachment 3313 [details] [review]
Proposed Patch

    


    


      



        
          Comment 2
        

        
          Julian Maurice

        

        
        

        
          2011-03-16 16:11:09 UTC
        

      






Why the created file reserves_waiting.inc is not included in any template? As is, it is useless.

    


    


      



        
          Comment 3
        

        
          MJ Ray (software.coop)

        

        
        

        
          2011-04-07 10:50:39 UTC
        

      






This bug is mentioned in:
Bug 5875 : waitingreserves highlighting now	depends on maxpickupdate http://lists.koha-community.org/pipermail/koha-patches/2011-March/014070.html

    


    


      



        
          Comment 4
        

        
          Paul Poulain

        

        
        

        
          2011-05-05 14:41:12 UTC
        

      






Owen, can you explain where QA fails ?

    


    


      



        
          Comment 5
        

        
          Owen Leonard

        

        
        

        
          2011-05-05 14:53:11 UTC
        

      






(In reply to comment #4)
> Owen, can you explain where QA fails ?

For the same reason Julian comments: The patch includes a file which isn't used.

    


    


      



        
          Comment 6
        

        
          Paul Poulain

        

        
        

        
          2011-08-01 16:28:33 UTC
        

      






This patch depends on 5872.
It uses the sub &GetMaxPickupDate from granular hold rules to calculate when a waiting reserve has to be cancelled.

Once the 5872 has been applied, this one can be rewritten (removing the .inc that is useless) and tested again

    


    


      



        
          Comment 7
        

        
          Paul Poulain

        

        
        

        
          2011-09-05 15:34:38 UTC
        

      






removing "patch sent" status, this patch will have to be rewritten

    


    


      



        
          Comment 8
        

        
          Paul Poulain

        

        
        

        
          2012-02-15 16:20:02 UTC
        

      






* unclear description of the feature
* missing file
* HTML::Template and not Template::Toolkit thing
* no Mantis number I could refer to

well, marking "wontfix", I don't remember exactly what it was for (& i'm supposed to have written it !