The sub GetBudgetHierarchy return aqbudgetperiods.budget_period_active to have acces to a new filtering way, more the neworderempty.pl page have a check box "shox all".
Created attachment 3453 [details] [review]
Created attachment 3571 [details]
The 'Show all' label is placed to the left of dropdown list instead of the right.
Can someone confirms this behavior? because i don't see any errors in the template.
To solve the layout problem I recommend replacing this markup at line 314 of neworderempty.tmpl:
<span class="label"> Show all :</span><input type="checkbox" id="showallbudgets" />
<label for="showallbudgets" style="float:none;width:auto;"> Show all: </label><input type="checkbox" id="showallbudgets" />
Is this checkbox supposed to trigger the display of inactive funds? It didn't do anything at all for me, but I suspect I don't have the right kind of budgets set up to properly test.
Please provide more details about how to test this properly.
Checkbox does nothing, because GetBudgetHierarchy returns only active funds.
I will submit a follow up patch with this modification, and Owen's fix for layout.
Created attachment 3573 [details] [review]
Follow up patch
This patch modify GetBudgetsHierarchy to returns all funds, not anly those that are parts of an active budget, and fix a layout problem.
Created attachment 3576 [details] [review]
Follow up patch
Remove useless comments
This bug is mentioned in:
Bug 5963 : Add the ability to filter budgets using the active column http://lists.koha-community.org/pipermail/koha-patches/2011-March/014250.html
Bug 5963: Modify GetBudgetsHierarchy to returns all funds http://lists.koha-community.org/pipermail/koha-patches/2011-March/014399.html
Bug 5963: follow up: Remove useless comments http://lists.koha-community.org/pipermail/koha-patches/2011-March/014400.html
Created attachment 3610 [details] [review]
Sqashed all 3 patches into one
Pushed, please test
*** Bug 6051 has been marked as a duplicate of this bug. ***