(MT #4937) The missing fields : publicationyear, place, collectiontitle. More the layout has been modified.
Created attachment 3707 [details] [review]
Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: BZ6070 On a new order defined from suggestion some fields were missing. (MT4937) The missing fields : publicationyear, place, collectiontitle. More the layout has been modified.
fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Created attachment 3830 [details] [review]
manuel rebase of initial patch
Manual rebase, should be better
This cannot apply because it edits the tmpl files and not the tt files.
Created attachment 4221 [details] [review]
updated patch uploaded
Created attachment 4222 [details] [review]
proposed patch (updated)
a --> from H::T::P was still here
Created attachment 4239 [details] [review]
follow up patch
Signed off on patch and have follow up for sign off.
I tested both patches and found some things:
1) The lables used in the new order form are different from the labels used in suggestions: Collection title / Collection, Publication Place / At, Copyright year / On. On and At are also a bit difficult for translation.
2) At and Collection didn't save for me. I filled out all fields, saved and checked summary page and order line (modify).
Checked on current master, MARC21, items are created in cataloging. (AcqCreateItem)
(In reply to comment #9)
> I tested both patches and found some things:
> 1) The lables used in the new order form are different from the labels used in
> suggestions: Collection title / Collection, Publication Place / At, Copyright
> year / On. On and At are also a bit difficult for translation.
Well spotted. I've updated the patch, adding some reordering to have fields in neworder in the same order as well.
> 2) At and Collection didn't save for me. I filled out all fields, saved and
> checked summary page and order line (modify).
Yikes ! something has disappeared on those patch (probably a rebase not carefull enough)
Created attachment 4796 [details] [review]
proposed patch (updated)
Not sure it's a reason to not sign off on this patch, but the form when ordering from a suggestion has a 'series' field that is not there on the opac or staff client when adding or managing suggestions.
Is collection title the same as series? Or are these different things?
Paul, can you resolve the collection/series confusion?
(at least in France) librarians use :
* "collection" when a monography is a "member" of a collection (like "fleuve noir"), grouping all books on a given topic/kind/subject/... for a given publisher
* "series" is used for series.
Is there the same kind of difference in marc21 ?
Maybe there's a glitch somewhere in my patch though. (A screenshot could help verifying)
Hi Paul, the problem is - neither form shows both. We have series on one and collection on the other. I suspect they both save to the same place, but that needs to be checked.
Hm, and I am not sure about the difference of series and collection. Perhaps traced and untraced series?
MARC21 does not really make the distinction between collection/series they are recorded in the same place. Traced/Untraced could differ between different institutions cataloguing practices (a legal library might trace some series that a general library won't) The term 'monograph series' is similar to Paul's collection (and sometimes collection is used in the book trade) but again if we use MARC21 there's no guaranteed way to distinguish. They all go to the 'series' field
Purchase suggestion in OPAC offers following fields:
- copyright date
- standard number
- collection title
- publication placce
- item type
- reason for suggestion
Suggestions in acquisitions:
All fields are present.
Problem 1) Small: inconsistency: item type is called document type.
Problem 2) Critical: Reason for suggestion has not been saved.
Problem 3) Critical: Mark selected as is missing 'Accept', only offering 'Asked', 'Checked' and 'Rejected'
Because of 3 I can't check creating an order from a suggestion.
2) is bug 6880 now.
3) is bug 6881 now
Ordering from a purchasse suggestion:
Purchase suggestion in OPAC offers following fields:
1) Normal: The field order differs from OPAC.
OPAC: collection title is after publisher
On order: collection title is last field after itym type
2) Critical: There is an additional field called 'Series' that shows up nowhere else.
3) Trivial: Reason for suggestion and notes are not shown here. Perhaps this is ok.
I am still not sure what collection title and series are - where are those saved to in MARC21? Do we need both?
3) of comment #18 will was solved by bug 6904
The other problems noted in comments #21 and #21 are still valid.
*** Bug 7087 has been marked as a duplicate of this bug. ***
Paul is this bug still an issue in master or can we close it?
(In reply to comment #25)
> Paul is this bug still an issue in master or can we close it?
Yes, it's still an issue.
* create a suggestion, with something in the fields labelled "publication place", "Collection title".
* accept the suggestion
* add the accepted suggestion to a basket. The form acqui/neworderempty.pl don't show the 2 fields anywhere. Plus the "publication place" appears nowhere and there is no field labelled "collection title", but a field labelled "series"
note that I checked the suggestions table, the 2 fields are properly stored in the database)
Created attachment 17493 [details] [review]
Bug 6070: publication place and [collection|series]title not properly saved
Before this patch, adding an order from a suggestion with a collection title and publication place resulted in loosing those informations
This patch fixes the behaviour by
* adding a biblioitems.place to TransformKohaToMarc call in addorder.pl
* adding publication place field in neworderempty template
* sending collectiontlte & place fields to templates
This patch also:
* does some reindenting in addorder.pl
* fixes some UCFirst coding guidelines errors in opac-suggestions.pl
OK, I've rewritten the patch after investigating & looking at comments.
I think what is confusing is that we have biblio.seriestitle AND biblioitems.collectiontitle fields.
This patch doesn't change that, but maybe we should remove one of them !
I can confirm that french "une collection" means "a series of monographs" in english.
Sometimes we use "série" in french, but I think it is not defined in Unimarc. In this case, "série" is used for a set of books with the same title, for example comic books or manga (Naruto is a série of XXX mangas, Tintin is a série of 22 books, etc). cf the blog of the main french record vendor, Electre : http://blog-electre.com/2012/03/30/astuce-vous-suivez-plusieurs-centaines-de-series/
I don't know how to translate this meaning of "série" in english.
("Série" is also used in "publication en série" = "serial" in english.)
Paul, Can you confirm the bug is still present in master? I cannot reproduce it.
For me, serial information and publication place are saved in master, either if I create the suggestion from OPAC, or from staff interface.
(By the way, I think publication place is not a very usefull information...)
We've just changed for Koha 3.14 and I see that the bug, reported by Paul Poulain, about the biblioitems.collectiontitle fields (UNIMARC 225Sa)in the orders, has not been resolved yet. The field is not saved between suggestions and orders. It's a real problem because we can't use fully koha to manage our acquisitions. I must use another software (ACCESS) to make the link between purchasers and suggestions, its a waste of time... pity.
Fabienne Heullant, Head Librarian
Frantiq, French archaeology libraries network (more than 40 libraries)
If it is still in master, it must be fixed!
And bug status should not be "in discussion".
But it is definitely not a "P1 blocker" bug.
You can see the definition of bug priority in the wiki
More likely something like "Normal P3"
I haven't tested/checked that the patch still applies, but it should not stay "in discussion", as that's a real bug.
Fridolin, can you have a look please ?
Does not apply on master or 3.14.x
Created attachment 27015 [details] [review]
[PATCH] Bug 6070: publication place and [collection|series]title not properly saved
Now when adding to a basket "Publisher/Publication place/Collection title" shows up, good.
But when viewing a basket you press Modify (ej. to alter quantity),
that information does not shows.
(In reply to Bernardo Gonzalez Kriegel from comment #38)
> But when viewing a basket you press Modify (ej. to alter quantity),
> that information does not shows.
I see this too: Specifically, publication place (from 260a) and "Collection title," actually series name, from 490a are not shown.
Is this bug still valid?