Bug 6234 - Links on hold ratios report broken
Summary: Links on hold ratios report broken
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Katrin Fischer
QA Contact: Bugs List
URL:
Keywords:
Depends on: 6241
Blocks: 5917
  Show dependency treegraph
 
Reported: 2011-04-21 13:59 UTC by Katrin Fischer
Modified: 2012-10-25 23:10 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (8.30 KB, patch)
2011-04-21 15:26 UTC, Katrin Fischer
Details | Diff | Splinter Review
Corrected patch (9.12 KB, patch)
2011-04-21 17:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2011-04-21 13:59:42 UTC
The links in hold ratios report are broken.
Comment 1 Katrin Fischer 2011-04-21 15:26:49 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2011-04-21 15:57:01 UTC
A couple of fixes required:

1. I think an instance was missed on /cgi-bin/koha/circ/waitingreserves.pl. The "holds over" tab still doesn't have working links.
2. I think the change to reserveratios.tt removing <p class="ratiolimit"> from the ratio is incorrect. This is unrelated to the TT conversion. It was added as part of Bug 3130. From the commit message, "I also added the hold ratio to a column display, with a jquery tweak to put it in the ratio input box on click."
Comment 3 Katrin Fischer 2011-04-21 17:38:35 UTC
Created attachment 3979 [details] [review]
Corrected patch

Made changes suggested by Owen.
Comment 4 Chris Cormack 2011-04-21 19:09:40 UTC
Pushed please test