Created attachment 4146 [details] [review]
In new templates, in some cases (I have found four) the singleBranchMode preference, when appearing in a loop, has been prefixed with the loop name, which is wrong.
As a result of changing the singleBranchMode preference has no impact on e.g. whether the library name is displayed or not in opac search results view.
A patch is attached.
This patch does not apply with git:
Patch format detection failed.
I am marking 'Does not apply' - perhaps someone can reformat?
Katrin, I have just resent the patch again to the list (yesterday my e-mail program introduced line breaks).
Please test it now.
Can you attach your new patch to the bug plz? You can mark the old one obsolete, so there will be no confusion about which patch should be used.
Created attachment 4181 [details] [review]
Proposed patch (with the header)
Could you, please, explain, why do you consider this bug as dependent on 6347? I do not get the point. It seems to me that these two bugs are fully independent. As to opac-results.tt: singleBranchMode is a "global" parameter/preference -- all I propose in my patch is removing the erroneous loop prefix from before it...
I can't test the part on reserve.tt because it applies to item level holds - which are currently broken. See here from the code:
[% IF ( OPACItemHolds ) %]
[% IF ( bibitemloo.holdable ) %]
<tr class="copiesrow" id="copiesrow_[% bibitemloo.biblionumber %]">
<td colspan="[% bibitemloo.itemtable_colspan %]">
<caption>Select a specific copy:</caption>
[% IF ( item_level_itypes ) %]
[% END %]
line you fixed > [% UNLESS ( bibitemloo.singleBranchMode ) %]
I believe your patch works, but at the moment I can't test properly. I tried to sign off the fix for item level holds, but ran into some problems.
Hope that explains.
Thank you, Katrin, for the explanation--now I get the point.
Created attachment 4295 [details] [review]
[SIGNED-OFF] Bug 6353: Erroneous prefixes before the singleBranchMode preference removed
Patch resent due to errors in formating in previous e-mail
Signed-off-by: Katrin Fischer <Katrin.Fischer.firstname.lastname@example.org>
- library facet
- library limit on advanced search
- library shown in item level hold table
TT error, pushed please test
There have been no further reports of problems so I am marking this bug resolved.