Bug 6608 - Date-pickers broken on guided reports pages
Summary: Date-pickers broken on guided reports pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-19 19:37 UTC by Owen Leonard
Modified: 2013-12-05 19:57 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (3.30 KB, patch)
2011-07-19 19:47 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2011-07-19 19:37:41 UTC
There is a Template:Toolkit variable scoping issue with the date-picker JavaScript configuration in the guided reports and dictionary templates.
Comment 1 Owen Leonard 2011-07-19 19:47:02 UTC
Created attachment 4671 [details] [review]
Proposed fix

Template variable scope errors.

The change to dictionary.tt can be tested by creating a dictionary definition based on a date-type table column (date of birth, registration date, etc). The date-picker widgets for "start of date range" and "end of date range" should work correctly.

The change to guided_reports_start.tt cannot be tested as far as I know because of bug 6607.
Comment 2 Ian Walls 2011-07-19 20:05:27 UTC
Template-only change, easy to read, marking as Passed QA
Comment 3 Chris Cormack 2011-07-19 21:39:36 UTC
Pushed, please test