The patron category edit page doesn't show SMS options even when an SMS driver is defined in system preferences. The preference variable isn't being passed to the template.
Created attachment 5437 [details] [review]
I don't understand and can't see what it adds. Is there something missing? Perl script is modified but not the related template.
Here are the conditions for observing the bug:
1. Turn on EnhancedMessagingPreferences
2. Fill the SMSSendDriver preference with any value to enable it
3. Edit a patron category
In the table of options labeled "Default messaging preferences for this patron category" you will see a column for Email but not for SMS. When the SMSSendDriver preference is populated there should also be a column for SMS. The template checks for the SMSSendDriver preference, but the script didn't pass the variable to the template. This patch corrects it to do so.
Created attachment 5594 [details] [review]
[SIGNED-OFF] Fix for Bug 6872 - Can't set default SMS messaging options for patron category
Passing SMS driver preference value to the template so that SMS
options can be displayed when appropriate.
Signed-off-by: Nicole C. Engard <firstname.lastname@example.org>
Simple fix, pushed, please test