Created attachment 7108 [details] [review]
Corrects the SQL query used to fetch all baskets of a booksellers.
If all the items in a basket are received, the basket doesn't appear in the bookseller's baskets list (/acqui/booksellers.pl).
I don't think having invisible baskets is a desired behavior, so here is a patch so all baskets are shown.
I think I disagree here - it seems to be desired behaviour.
When ordering over a long period of time the list of baskets you see will grow endlessly. It will be hard to find newer baskets and baskets where not all books have been received. Also if I am not mistaken here, the list will be even longer for a search that brings up more than one vendor on that page.
I think perhaps an option to 'show all' would be better?
And it should be possible to use the search to find older orders.
I believe we need a new bit of mechanics: 'archived'. Baskets will stay visible for a vendor until they're archived. Many libraries need to keep baskets visible for a while after they've been received (since, while Koha assumes that 'received' == 'paid for', that's not actually true). But, as Katrin points out, we don't want EVERY basket EVER to show up.
If we add an 'archive' button, and possibly a syspref to "archive when all items received", we'd have the best of both worlds.
How would the workflow for archiving be?
I am not sure you can actually see when all items from a basket have been received on the received screen. Perhaps the "finish receive" button could integrate an alert for achiving of baskets that have been fully received?
I think making the librarian go back to the basket to check if everything was received will not work.
I think we shouldn't change the current behaviour without giving this some thought.
I agree with Katrin : if all the basket appear in /acqui/booksellers.pl, it becomes very difficult to load the page at the end of the year.
To see the basket where all the items are received, we can use the search page (koha/acqui/histsearch.pl), no ?
In 3.8, all the baskets are listed in /acqui/booksellers.pl and for me it's a real problem.
A restriction should be added in sub GetBasketsInfosByBookseller in src/C4/Acquisition.pm to fix that ?
Marking as invalid as since 3.8 all baskets are shown. The request to only show baskets with expected items should be in a new ticket.