In Serials, on the summary of a subscription, four different notes (nonpublic note, public note, and 2 notes for history) are displayed in one line for each.
But when we edit the subscription, it's possible (and tempting) to type the content on several lines.
We could try to display these notes on several lines in an elegant way (not so easy because the layout seems to be optimized for one-line informations).
Created attachment 8924 [details] [review]
proposed patch #1
A first and very simple version of what we can do. But the first line is not aligned with the others...
Did you want a signoff now, or would you like to wait for a follow up is done to fix the layout issues?
I'd like to read a few opinions about this. If this version is considered ok, then we can sign it off, but if someone has a better idea, I could implement it.
Created attachment 10317 [details] [review]
[SIGNED-OFF] Bug 7905: display serial notes on several lines
Signed-off-by: Katrin Fischer <Katrin.Fischer.firstname.lastname@example.org>
Patch works and makes use of TT filters!
I agree the display could be improved to work a bit nicer
for long lines or multi-line comments, but this is still a nice
Created attachment 10319 [details] [review]
Bug 7905: Follow up - Multi-line subscription notes
This patch adds the TT filter to other places where we are displaying the
- OPAC detail page, subscription tab
- OPAC subscription brief history page
- Staff detail page, subscription tab
Both patches are template only, and add the HTML line break filter to fields that are known to have line breaks. Marking Passed QA on both.
There have been no further reports of problems so I am marking this bug resolved.