Bug 8107 - Disabled buttons not distinguishable from enabled buttons.
Summary: Disabled buttons not distinguishable from enabled buttons.
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 12:10 UTC by Kyle M Hall
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 8107 - Disabled buttons not distinguishable from enabled buttons (1.41 KB, patch)
2012-05-18 15:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 8107 - Disabled buttons not distinguishable from enabled buttons (1.54 KB, patch)
2012-05-20 07:46 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2012-05-16 12:10:13 UTC
Disabled buttons in Koha appear no different than enabled buttons. We should really have some CSS in Koha to make disabled buttons distinguishable from enabled ones
Comment 1 Owen Leonard 2012-05-18 15:54:21 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-05-20 07:46:11 UTC
Created attachment 9662 [details] [review]
Bug 8107 - Disabled buttons not distinguishable from enabled buttons

Add a "greyed-out" style for disabled buttons.

Having looked through the templates for examples of usage of this
I'm not convinced that we should really be showing disabled buttons.
I think in general it would be better to hide or show a button
based on whether the action is available.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

I agree, I think hiding or showing is better, but this patch is
harmless enough, until we want to go fixing our usage
Comment 3 Jonathan Druart 2012-05-22 08:48:21 UTC
QA Comments:
Simple ergonomic modification
Passed QA.
Comment 4 Paul Poulain 2012-05-25 15:32:07 UTC
probably usefull and harmless to backport to 3.8
Comment 5 Chris Cormack 2012-05-28 10:10:33 UTC
Pushed to 3.8.x, will be in 3.8.2