Created attachment 10256 [details] [review]
Same thing than bug Bogue 7888 but in members tab : allow a use with edit borrowers permission to change the password.
Patch changes permisison for "change password" button in members-toolbar.inc from staffaccess to borrowers.
To test :
- With a staff user with borrowers permission, verify the change password button is shown for a normal patron.
- With a staff user without borrowers permission, verify the change password button does not appear.
The change is logical and works as expected. I am only wondering under which circumstances it was possible to reach the page with staffaccess but without borrowers permission? Both the memberentry and the passwordchange template require borrowers permission to be accessible.
I think at some point in time it was not possible for staff users to change their own or the passwords of other staff members. Passwords could be changed in OPAC or by the superlibrarian. I am not sure when this changed, but the change is not dependend on this patch.
Do we want it to work this way or should the former feature be restored?
Created attachment 10331 [details] [review]
[SIGNED-OFF] Permission for change password button in members toolbar should be borrowers instead of staffaccess
Signed-off-by: Katrin Fischer <Katrin.Fischer.firstname.lastname@example.org>
Changes permissions for member's password modification. It seems logical.
Marking as Passed QA.
I think it's more a bugfix than an ENH, chris_c, your final decision
Pushed to 3.8.x, will be in 3.8.3