Bug 8261 - Cannot search system preferences from Local Use tab
Summary: Cannot search system preferences from Local Use tab
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Fridolin Somers
QA Contact: Jonathan Druart
: 7522 (view as bug list)
Depends on:
Reported: 2012-06-18 07:20 UTC by David Cook
Modified: 2013-12-05 19:59 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Proposed patch (3.66 KB, patch)
2012-08-29 15:07 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 8261: Cannot search system preferences from Local Use tab (3.71 KB, patch)
2012-08-30 00:34 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2012-06-18 07:20:08 UTC
Searching the system preferences from the Local Use tab generates a Software error as follows:

"Template process failed: file error - .../intranet/htdocs/intranet-tmpl/prog/en/modules/admin/preferences/all.pref: not found at .../lib/C4/Templates.pm line 127."

I notice that early versions (such as 3.2) produce search results under an "all preferences" heading. However, I don't see an all.pref file in 3.2 either. 

The "all preferences" result list seems archaic though, since searching "OPAC" or "MARC" from any other tab provides a much more well formatted list where results are grouped by tab and subheading. 

Any thoughts on this one?
Comment 1 Marc Véron 2012-06-24 18:24:05 UTC
*** Bug 7522 has been marked as a duplicate of this bug. ***
Comment 2 Marc Véron 2012-06-24 18:27:17 UTC
This bug was already reported by Bug 7522. I marked 7522 as duplicate.

I can confirm the bug (Version )

Comment 3 Fridolin Somers 2012-08-29 15:07:07 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2012-08-30 00:34:26 UTC
Created attachment 11884 [details] [review]
Bug 8261: Cannot search system preferences from Local Use tab

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Jonathan Druart 2012-09-04 13:00:56 UTC
Maybe I have make a mistake but apparently there are 2 pages for manage syspref: admin/systempreferences.pl and admin/preferences.pl. This last one is used.
And the corresponding tt files.

Let me know if I forgot something, but I am under the impression we can remove the following files:

And we just replace the l.11 koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc
[% IF ( local_use ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/admin/systempreferences.pl">Local use</a></li>
Comment 6 Owen Leonard 2012-09-04 13:07:38 UTC
Don't we need systempreferences.pl/.tt for Local use preferences?
Comment 7 Jonathan Druart 2012-09-04 13:23:39 UTC
(In reply to comment #6)
> Don't we need systempreferences.pl/.tt for Local use preferences?

Yes :-/
But a big part of systempreferences.pl seems useless.
I will open a new Bug.
Comment 8 Jonathan Druart 2012-09-04 13:26:30 UTC
see Bug 8720
Comment 9 Jonathan Druart 2012-09-04 13:26:51 UTC
This one passes QA :)
Comment 10 Paul Poulain 2012-09-05 13:51:46 UTC
Patch pushed to master
Comment 11 Chris Cormack 2012-09-06 07:39:12 UTC
Pushed to 3.8.x, will be in 3.8.5