The SIPserver uses a libpath different from the rest of Koha its passed in the upscript using -I. having cd'd to the C4/SIP directory.
Perl has a perfectly good way to manage this rather than relying on -I being set correctly in a calling script. Using it may remove a barrier to setting up and debugging sip configurations.
Created attachment 10361 [details] [review]
Corrected status of this
Created attachment 10573 [details] [review]
Bug 8271 teach SIPServer.pm to set its own lib path
SIPServer.pm requires that C4/SIP is added to its lib
path This has been done by passing this directory
to it via -I. By using FindBin it can set the path
for itself correctly. This will also work if the C4/SIP
directory tree is moved to a non-standard location
Removed the now redundant -I. from sip_run.sh
Added a variable to sip_run.sh for the koha tree to
highlight a problem with the script if you have multiple
directories in the PERL5LIB environment variable
Signed-off-by: Chris Cormack <firstname.lastname@example.org>
QA comment: small change, passes QA without any problem
I haven't tested this patch, but I trust Colin enough to push it
(chris_c, not sure it should be ported to 3.8, but maybe)
There have been no further reports of problems so I am marking this bug resolved.