Bug 8514 - Display of patron results changed display order
Summary: Display of patron results changed display order
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Colin Campbell
QA Contact:
Depends on:
Reported: 2012-07-27 10:59 UTC by Colin Campbell
Modified: 2013-12-05 19:59 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:

Proposed Patch (4.08 KB, patch)
2012-07-27 15:41 UTC, Colin Campbell
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 8514 Restore Patron Name Display Order (4.15 KB, patch)
2012-07-27 15:57 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Campbell 2012-07-27 10:59:01 UTC
As part of the patch associated with bug 6303 the display of patrons returned by a seach has changed from surname, firstname to firstname surname. As that change is not flagged in the commit message or associated bug I assume this was inadvertant. Libraries seeing the newer display are seeing it as a regression
Comment 1 Colin Campbell 2012-07-27 11:05:27 UTC
NB See also bug 8427 a problem with sorting the results that may be obscured by this one
Comment 2 Colin Campbell 2012-07-27 15:41:33 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2012-07-27 15:57:08 UTC
Created attachment 11171 [details] [review]
[SIGNED-OFF] Bug 8514 Restore Patron Name Display Order

Bug 6303 introduced an include file governing patron name display
unfortunately that changed patron display in search result lists and
on the circ screen header. This adds a parameter restroring the
original surname, firstname order, whose absence was perceived
as a loss of functionality

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Mason James 2012-08-10 05:46:43 UTC
(In reply to comment #3)
> Created attachment 11171 [details] [review]
> [SIGNED-OFF] Bug 8514 Restore Patron Name Display Order
> Signed-off-by: Owen Leonard <oleonard@myacpl.org>

patch looks good, passing QA

mason@xen1:~/git/head$ koha-qa.pl 
        * 53b4f14 Bug 8514 Restore Patron Name Display Order

- perlcritic-progressive tests... OK
- perl -c syntax tests... OK
- xt/tt_valid.t tests... OK
- xt/author/valid-template.t tests... OK
Comment 5 Chris Cormack 2012-08-10 22:06:33 UTC
Pushed to 3.8.x, will be in 3.8.4
Comment 6 Paul Poulain 2012-08-31 16:31:37 UTC
QA comment: IIRC, we introduced patron-title to be sure we have a consistent display of the patron everywhere. This patch reintroduces the possibility of having the display inconsistent.

I think it is to let the librarian being able to sort the table by surname, isn't it ?
However, I think it's worth being discussed. 3 option:
 * we reintroduce the possibility to be inconsistent
 * we switch to surname firstname everywhere
 * we keep firstname surname (and discard this patch)

Any other option or anything I misunderstood welcomed !
Comment 7 Colin Campbell 2012-09-01 13:16:22 UTC
I think a single consistent format everywhere is not desirable. In the real world our names appear in different formats depending on the context. In lists (e.g. a phonebook) inverted is the norm in singular uses (e.g. addressing a letter, introductions) uninverted form. Forcing all formats to follow one or the other is seen by users as unnatural and disrupting to the work flow. The removal of inverted form from search result lists seriously disrupts the usefulness of those lists for large institutions.
Comment 8 Chris Cormack 2012-09-03 20:31:21 UTC
I think I agree with Colin here, you do often want things displayed in different ways depending on context.
Comment 9 Paul Poulain 2012-09-05 13:22:59 UTC
Patch pushed to master