Bug 8583 - Add a warning if a Z39.50 search is started from the "Edit biblio record" page
Summary: Add a warning if a Z39.50 search is started from the "Edit biblio record" page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor (vote)
Assignee: Frédérick Capovilla
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 9742
  Show dependency treegraph
 
Reported: 2012-08-06 19:39 UTC by Frédérick Capovilla
Modified: 2016-08-25 10:19 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Add a warning if a Z39.50 search is started from biblio edition page. (2.27 KB, patch)
2012-08-06 19:39 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
[SIGNED-OFF] Add a warning if a Z39.50 search is started from biblio edition page. (2.53 KB, patch)
2012-09-06 19:28 UTC, Marc Véron
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédérick Capovilla 2012-08-06 19:39:32 UTC Comment hidden (obsolete)
Comment 1 Frédérick Capovilla 2012-08-06 19:40:05 UTC
Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )
Comment 2 Jared Camins-Esakov 2012-08-28 02:39:57 UTC
Owen had a good suggestion. Rather than adding an additional click every time someone clicks the "Z39.50 Search" button, perhaps we could change the label to something like "Replace with Z39.50"?
Comment 3 Marc Véron 2012-09-06 19:28:50 UTC
Created attachment 12026 [details] [review]
[SIGNED-OFF] Add a warning if a Z39.50 search is started from biblio edition page.

Warn the user that the current biblio record might be overwritten by
this action.

http://bugs.koha-community.org/show_bug.cgi?id=8583
Signed-off-by: Marc Veron <veron@veron.ch>

Woks as expected. I prefer this solution with an explicit warning,
since several times I acidentally changed a record  :-)
Comment 4 Paul Poulain 2012-10-02 16:03:20 UTC
QA comment:
 * tiny patch, no side effect risk
 * passes koha-qa.pl

passed QA

Question: why does the message say: "could replace" ? It "will" replace isn't it ?
Comment 5 Paul Poulain 2012-10-02 16:03:59 UTC
Patch pushed to master.

More a minor bugfix than an ENH, but chris, up to you, as usual
Comment 6 Chris Cormack 2012-10-03 19:21:36 UTC
Pushed to 3.8.x will be in 3.8.6
Comment 7 Katrin Fischer 2013-03-04 07:32:40 UTC
I am not sure I like this change - actually I think it's a bit annoying for an experienced cataloger. Wouldn't it be better to change the button labelling maybe? It could say "Z39.50 overlay" or something else that makes sense in English. Also, the prompt always appears, even for a totally empty that has not been saved yet. It's totally unnecessary in this case.
Comment 8 Katrin Fischer 2013-03-04 07:42:19 UTC
I have filed a separate bug - maybe we can just make it appear a bit less often by eliminiating the prompt for a new record (bug 9742)?

I understand the idea behind this - I was only taken a bit by surprise today when testing something else.