"Copy cataloging via Z39.50 is often done by searching on ISBN or ISSN. Unfortunately, the code for doing this is... problematic, and may cause problems with some Z39.50 servers." (Description from Bug 8550).
This Bug is the Exact Same bug as 8550. Except it is in the Z39.50 Search Script located in the Acquisitions Module. /usr/share/koha/intranet/cgi-bin/acqui/z3950_search.pl
The z3950_search.pl script for the Acquisitions Module has a few extra lines of code to handle Ordering of the item.
Created attachment 12401 [details] [review]
Z39.50 ISBN Search is problematic and there is a missing ISSN field.
The changes made a duplicate fixes. Bug 8550 was for the Cataloguing module. Bug 8680 is for the Acquisitions module.
Created attachment 12609 [details] [review]
[SIGNED-OFF] Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field.
The changes here are duplicate fixes.
The cataloguing directory had the same bugs as the acqui directory.
The bugs in the cataloguing files of the same name were fixed in Bug 8550.
The bugs in the acqui files had not been fixed.
This will fix Bug 8680 which is in the Acquisitions Module.
Changes to the z3950_search.pl file:
Rather than treating ISBN and ISSN as the same, this patch breaks
them out into separate parts of the query, as well as changing
the truncation attribute to enable right truncation (the correct
behavior for the ISBN field in MARC21, and valid behavior in
Changes to the z3950_search.tt file:
Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search
page, and the ISBN field replaced with a combined ISBN/ISSN field. Since
this breaks ISBN search for most Z39.50 targets (due to the
differing treatment of ISBN vs. ISSN), this is a bug not a feature.
Signed-off-by: Marc Veron <firstname.lastname@example.org>
Works as expected.
(In reply to comment #2)
> Created attachment 12609 [details] [review]
> [SIGNED-OFF] Bug 8680 Z39.50 ISBN Search is problematic and there is a
> missing ISSN field.
> > Signed-off-by: Marc Veron <email@example.com>
> Works as expected.
tested works as expected, passing QA...
$ koha-qa.pl -c 1
testing 1 commit(s) (applied to commit 6c18204)
* 76fc1dc Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field.
* acqui/z3950_search.pl OK
* koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt OK
Patch pushed to master
Pushed to 3.8.x, will be in 3.8.6