The description for the OpacHiddenItems preference says to refer to "docs/opac/OpacHiddenItems.txt." We have help files included with Koha and a manual online. We should point the user to one of those resources instead of one which isn't web-accessible and which isn't translated.
Pull request on GitHub: https://github.com/Koha-Community/Koha/pull/1
Replaced all references to docs/opac/OpacHiddenItems.txt to refer to online documentation. In most cases, this was the English documentation (http://manual.koha-community.org/3.8/en/administration.html#OpacHiddenItems), but referred to French documentation (http://manual.koha-community.org/3.8/fr/opacprefs.html#OpacHiddenItems) in the fa-Arab, fr-FR, and sq-AL files.
In addition to the ~60 .po files, there were three more files that I changed:
P.S. Sorry for taking your bug... :-(
Thanks heaps for your work, however, you shouldn't change the .po files, they are automatically generated, and then translated at http://translate.koha-community.org
If you could rebase your commit, and remove the changes to the .po files (just the 3 other files are all that are needed to be changed).
Then if you attach that here as a patch, it can go to needs signoff, and another developer can sign off on it.
Created attachment 12733 [details] [review]
Proposed patch for Bug 8701
Thanks for your guidance. Here is the bug fix without the .po files -- just the 3 files that needed to be changed. I've attached a patch; let me know if the patch is not as it should be. Sorry, I'm new to all of this -- thanks for your understanding. :-)
(In reply to comment #2)
> Hi Jane
> Thanks heaps for your work, however, you shouldn't change the .po files,
> they are automatically generated, and then translated at
> If you could rebase your commit, and remove the changes to the .po files
> (just the 3 other files are all that are needed to be changed).
> Then if you attach that here as a patch, it can go to needs signoff, and
> another developer can sign off on it.
> Thanks again
You are doing great, just a few issues now, by changing the old updatedatabase.pl statement, this will mean this change will not be made to anyone upgrading from any version later than 3.4.0.
So we might have to add another update stanza to change the value for those who have already updated?
Also, while I would be willing to push this for 3.8.x (with the above change) for 3.10 it should probably point to the 3.10 .. manual .. and then for 3.12 etc.
So this will need to be updated each feature release, I wonder if we can figure out a better way. But for 3.8.x im happy to push this (once it updates for upgrades also).
Thanks so much for working on this, we really appreciate any time anyone can spend bug fixing.
thanks a lot for working on this. Changing the bug status to "in discussion" for now as it needs another database update as Chris explained. If you have any questions feel free to ask :)