Found this in 3.6.3, but it applies to 3.6.x, 3.8.x, and master.
1) Log in to staff client
2) Click 'Koha administration'
3) Click 'MARC Bibliographic framework'
4) Choose a framework and click 'MARC structure'
5) Check 'Display only used Tags/Subfields'
6) Check koha error log
[Mon Sep 03 12:06:06 2012] [error] [client 192.168.100.2] [Mon Sep 3 12:06:06 2012] marctagstructure.pl: Use of uninitialized value in numeric eq (==) at /usr/share/koha/intranet/cgi-bin/admin/marctagstructure.pl line 284., referer: https://.../cgi-bin/koha/admin/marctagstructure.pl
284 is the bottom of the loop, but the top of the loop had "and boundary check" logic instead of "boundary check and" logic. Correcting this ordering problem fixed the bug.
Created attachment 11942 [details] [review]
Changed and statement to have boundary check first.
This is one of those strange bugs where the line number for the error number is not where the error is. Fixing the condition in the while loop fixes the warning generated by the test plan already posted on this bug.
Created attachment 11953 [details] [review]
Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl
An array boundary check was after a comparison using the array.
By changing the logic which had " and ( $j < $cnt)" to be at the
beginning "( $j < $cnt ) and ", the warning is no longer shown
in the error log.
Signed-off-by: Jonathan Druart <firstname.lastname@example.org>
> Signed-off-by: Jonathan Druart <email@example.com>
patch looks good, passing QA…
testing 1 commit(s) (applied to commit 0acebb8)
* 146447b Bug 8714 - Poorly ordered and triggers warning in marctagstructur
* admin/marctagstructure.pl OK
Patch pushed to master
Pushed to 3.8.x, will be in 3.8.5