Bug 8987 - "New report button" broken
Summary: "New report button" broken
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Galen Charlton
QA Contact:
Depends on:
Reported: 2012-10-30 14:48 UTC by Ed Veal
Modified: 2013-12-05 20:01 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Note You need to log in before you can comment on or make changes to this bug.
Description Ed Veal 2012-10-30 14:48:10 UTC
There is a button that appears in the reports module for staff who have
permission to create new reports.  Clicking on the button opens a drop-down for
the options "Guided report" or "SQL report." 

I notice now that after the upgrade from 3.8.4 to 3.8.5 this button has fallen
to pieces. I have also seen that this issue is still happening in 3.8.6 The options are still available - they're just not drop downs on the button any more - they appear as html links in the space where the button used to be.  And they appear on the screen for everyone who has permission to run reports - whether or not they have the permission to create reports.

Comment 1 Owen Leonard 2012-10-30 15:21:59 UTC
There is a JavaScript error causing an interruption to JS processing, resulting in the broken button. The error:

TypeError: $(".datepicker").datepicker is not a function
Line 311

".datepicker" is related to the jQueryUI datepicker, so it looks like an update was picked from master which shouldn't have been.
Comment 2 Chris Cormack 2012-10-30 21:24:33 UTC
Right ill hunt this down and fix it.
Comment 3 Chris Cormack 2012-10-30 21:28:48 UTC
Here is the commit that added it


Bug 8596, the datepicker not enforcing iso formatted dates.

That definitely needs to be reverted?
Comment 4 Owen Leonard 2012-10-31 12:44:47 UTC
(In reply to comment #3)
> That definitely needs to be reverted?

Yes, it applies to master only. Sorry to have not made that clear in the patch.
Comment 5 Chris Cormack 2012-11-01 10:03:00 UTC
The commit causing this has been reverted from 3.8.x