In the lists interface the options for downloading have been moved into a menu button. In the cart the download button still pops up a separate window with download format options. The cart should be modified to match the lists interface, with an integrated menu button and no pop-up.
Created attachment 13568 [details] [review] Bug 9073 - Download option from the cart should match the menu button in lists This patch moves the staff client Cart download choices into a toolbar menu button instead of requiring that the user make the choice via a form in the pop-up window. To test, add items to Cart in the staff client. Open the cart and choose a download option from the Download menu. Your download should complete correctly without the page changing or reloading. Unrelated edit: Eliminating duplicate document.ready() block by consolidating a couple of lines of JavaScript.
Created attachment 13577 [details] [review] Bug 9073 - Download option from the cart should match the menu button in lists This patch moves the staff client Cart download choices into a toolbar menu button instead of requiring that the user make the choice via a form in the pop-up window. To test, add items to Cart in the staff client. Open the cart and choose a download option from the Download menu. Your download should complete correctly without the page changing or reloading. Unrelated edit: Eliminating duplicate document.ready() block by consolidating a couple of lines of JavaScript. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 13661 [details] [review] [SIGNED-OFF] Bug 9073 - Download option from the cart should match the menu button in lists This patch moves the staff client Cart download choices into a toolbar menu button instead of requiring that the user make the choice via a form in the pop-up window. To test, add items to Cart in the staff client. Open the cart and choose a download option from the Download menu. Your download should complete correctly without the page changing or reloading. Unrelated edit: Eliminating duplicate document.ready() block by consolidating a couple of lines of JavaScript. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked all export formats can be selected and downloaded, including CSV profiles. All tests and perlcritic pass.
Hi Owen, I think this would be a nice change for the OPAC cart interface too.
This patch has been pushed to master.
Pushed to 3.10.x will be in 3.10.1
Pushed to 3.8.x will be in 3.8.8
Pushed to 3.6.x will be in 3.6.11.