Bug 9073 - Download option from the cart should match the menu button in lists
Summary: Download option from the cart should match the menu button in lists
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-14 13:39 UTC by Owen Leonard
Modified: 2020-05-06 20:26 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9073 - Download option from the cart should match the menu button in lists (3.81 KB, patch)
2012-11-20 17:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9073 - Download option from the cart should match the menu button in lists (3.86 KB, patch)
2012-11-21 13:26 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9073 - Download option from the cart should match the menu button in lists (4.00 KB, patch)
2012-11-25 21:42 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2012-11-14 13:39:47 UTC
In the lists interface the options for downloading have been moved into a menu button. In the cart the download button still pops up a separate window with download format options. The cart should be modified to match the lists interface, with an integrated menu button and no pop-up.
Comment 1 Owen Leonard 2012-11-20 17:55:27 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2012-11-21 13:26:28 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2012-11-25 21:42:39 UTC
Created attachment 13661 [details] [review]
[SIGNED-OFF] Bug 9073 - Download option from the cart should match the menu button in lists

This patch moves the staff client Cart download choices into a toolbar
menu button instead of requiring that the user make the choice via a form
in the pop-up window.

To test, add items to Cart in the staff client. Open the cart and
choose a download option from the Download menu. Your download
should complete correctly without the page changing or reloading.

Unrelated edit: Eliminating duplicate document.ready() block by
consolidating a couple of lines of JavaScript.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked all export formats can be selected and downloaded, including
CSV profiles.
All tests and perlcritic pass.
Comment 4 Katrin Fischer 2012-11-25 21:43:13 UTC
Hi Owen,
I think this would be a nice change for the OPAC cart interface too.
Comment 5 Jared Camins-Esakov 2012-11-25 23:19:31 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2012-11-26 06:53:15 UTC
Pushed to 3.10.x will be in 3.10.1
Comment 7 Chris Cormack 2012-11-26 07:55:13 UTC
Pushed to 3.8.x will be in 3.8.8
Comment 8 Liz Rea 2012-11-28 22:40:59 UTC
Pushed to 3.6.x will be in 3.6.11.