Bug 9813 - Update About page with license information about Bootstrap and jQuery
Summary: Update About page with license information about Bootstrap and jQuery
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-13 18:24 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9813 - Update About page with license information about Bootstrap and jQuery (1.95 KB, patch)
2013-03-13 19:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9813 - Update About page with license information about Bootstrap and jQuery (2.03 KB, patch)
2013-03-14 03:51 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 9813 - Update About page with license information about Bootstrap and jQuery (2.03 KB, patch)
2013-03-14 11:20 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 9813 - Update About page with license information about Bootstrap and jQuery (2.08 KB, patch)
2013-03-17 08:53 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 9813 - Update About page with license information about Bootstrap and jQuery (2.11 KB, patch)
2013-03-19 08:17 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 9813 - Update About page with license information about Bootstrap and jQuery (2.15 KB, patch)
2013-03-19 09:48 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-03-13 18:24:36 UTC
According to http://twitter.github.com/bootstrap/ the following license terms cover Bootstrap:

Code licensed under Apache License v2.0, Glyphicons Free (which we include in original and modified versions) licensed under CC BY 3.0.
Comment 1 Owen Leonard 2013-03-13 19:00:16 UTC
jQuery projects (including both jQuery and jQueryUI) are licensed under the MIT license.
Comment 2 Owen Leonard 2013-03-13 19:05:51 UTC Comment hidden (obsolete)
Comment 3 Liz Rea 2013-03-14 03:51:13 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-03-14 10:55:14 UTC
Owen, don't we want jQuery and Bootstrap in a h2 title, not h3?
Comment 5 Liz Rea 2013-03-14 11:20:47 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-03-14 14:38:15 UTC
Thanks Liz!

On an ergonomic point of view it looks good.

On a juridic point of view, it was already debated.

Apache v2 is GPLv3 compatible (http://www.apache.org/licenses/GPL-compatibility.html), so no problem.

I just have a little question about Glyphicons Free, on its license page (http://glyphicons.com/glyphicons-licenses/), I understand: if the CC BY 3.0 is used, we should include the url (to glyphicons.com) on every page they appear.
As we used the icon set from bootstrap, don't we use it under the Apache v2 license? (And so the link appears in the about page, as requested).

Sorry if I misunderstood something or I the question has already been asked.
Comment 7 Liz Rea 2013-03-14 21:15:46 UTC
Glyphicons website says:

Glyphicons Halflings are also a part of Bootstrap by Twitter, and are released under the same license as Bootstrap. While you are not required to include attribution on your Bootstrap-based projects, Iā€™d certainly appreciate a visibile link back to glyphicons.com in any place you find appropriate (footer, docs, etc).

I think the visible link in the about page should cover it for the intranet.
Comment 8 Liz Rea 2013-03-14 21:16:17 UTC
http://glyphicons.com/glyphicons-licenses/ 

our case is the "included in bootstrap" case.
Comment 9 Jonathan Druart 2013-03-15 08:25:59 UTC
(In reply to comment #8)
> http://glyphicons.com/glyphicons-licenses/ 
> 
> our case is the "included in bootstrap" case.

Yes, so don't we point out we use Glyphicons Free under the Apache License v2 instead of the CC BY 3.0 license?
Comment 10 Liz Rea 2013-03-17 08:53:55 UTC Comment hidden (obsolete)
Comment 11 Paul Poulain 2013-03-19 08:17:30 UTC
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Comment 12 Paul Poulain 2013-03-19 08:17:48 UTC Comment hidden (obsolete)
Comment 13 Jonathan Druart 2013-03-19 09:41:56 UTC
QA comment:

Looks to me now.
This patch adds license Apache License v.2.0 for Bootstrap and Glyphicons Free and MIT License for jQuery and jQueryUI. 

Marked as Passed QA.
Comment 14 Jonathan Druart 2013-03-19 09:48:14 UTC
Created attachment 16342 [details] [review]
Bug 9813 - Update About page with license information about Bootstrap and jQuery

This patch adds license information about Bootstrap, jQuery, and
jQueryUI to the About page in the staff client.

To test, view the About page and confirm that information appears about
Bootstrap, jQuery, and jQueryUI with working links.

Fixed a small typo and changed erroneous h3's to h2's to match the other listings
Moved glyphicons link to indicate that it is licensed under the same terms as bootstrap - with Apache 2.0 license and not CC-BY.

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 15 Jared Camins-Esakov 2013-03-20 00:50:54 UTC
This patch has been pushed to master.