Bug 9893 - Koha::DateUtils::output_pref should not use $dateonly parameter
Summary: Koha::DateUtils::output_pref should not use $dateonly parameter
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 15:19 UTC by Jared Camins-Esakov
Modified: 2023-12-28 20:42 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2013-03-21 15:19:02 UTC
The fourth parameter to Koha::DateUtils::output_pref is $dateonly, which allows the user to specify that the time should not be included in the returned date string. Now that there is a $force_time format (which perhaps might be better called $date_format), it would probably be better to eliminate $dateonly, and use a time format of "none" when the time is not wanted.
Comment 1 Katrin Fischer 2023-01-08 00:59:08 UTC
Martin or Joubu, could you assist me in my quest to clean up the 4 digit bugs and let me know if this is still desirable? :)
Comment 2 Jonathan Druart 2023-02-01 10:20:48 UTC
Could be, but that's not going to bring us many benefits.

And I actually think I prefer to have it separate, especially because timeformat is also a syspref.