Bug 17486 removed the fifth parameter in checkauth which was used as the email check in opac/svc/auth/googleopenidconnect This should restore whatever is necessary to get Google OpenID connect to work.
Created attachment 60447 [details] [review] Bug 18144: Restore pieces of C4/Auth to make Google OpenID Connect work By restoring some pieces of logic, with the name changed from $persona to $emailaddress, the openid will work again for OPAC logins. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988#c68 for an excellent test plan.
Increasing priority, as a broken authentication method is kind of important to fix.
Should we perhaps use Koha::Patrons in preference to C4::Members?
(In reply to Srdjan Jankovic from comment #3) > Should we perhaps use Koha::Patrons in preference to C4::Members? While that may be a valid suggestion, the point was to paste back the code the way it was as much as possible.
Though admittedly, I renamed $persona to $emailaddress, to better represent what it is being used for now.
Created attachment 61516 [details] [review] [SIGNED-OFF] Bug 18144: Restore pieces of C4/Auth to make Google OpenID Connect work By restoring some pieces of logic, with the name changed from $persona to $emailaddress, the openid will work again for OPAC logins. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988#c68 for an excellent test plan. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 61589 [details] [review] Bug 18144: Restore pieces of C4/Auth to make Google OpenID Connect work By restoring some pieces of logic, with the name changed from $persona to $emailaddress, the openid will work again for OPAC logins. See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988#c68 for an excellent test plan. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Did not test it, but trust in author and signoffer
Oops, sorry about that. The call is: opac/svc/auth/googleopenidconnect: checkauth( $query, 1, {}, 'opac', $email );
Pushed to master for 17.05, thanks Mark!
bug 17586 is not in 18144, so this should not be needed. Please let me know, if I should be mistaken.