Bugzilla – Attachment 115209 Details for
Bug 27023
Add class names in the suggestions column in suggestions management
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27023: Add class names in acq suggestion table (suggestions column)
Bug-27023-Add-class-names-in-acq-suggestion-table-.patch (text/plain), 4.01 KB, created by
Lucas Gass (lukeg)
on 2021-01-15 15:50:58 UTC
(
hide
)
Description:
Bug 27023: Add class names in acq suggestion table (suggestions column)
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2021-01-15 15:50:58 UTC
Size:
4.01 KB
patch
obsolete
>From 5271bbc675b515d99c3d7666ac27639d2853e408 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 13 Nov 2020 23:01:29 +0000 >Subject: [PATCH] Bug 27023: Add class names in acq suggestion table > (suggestions column) > >Test plan: >1. Apply patch >2. Add some suggestions via the OPAC, fill out all the input fields >3. Go to the suggestion managemnet page and look specficially at the Suggestions column. >4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 1927b6f858..092ec5d9e8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -603,9 +603,9 @@ > <a href="suggestion.pl?suggestionid=[% suggestions_loo.suggestionid | uri %]&op=show" title="suggestion" > > [% suggestions_loo.title | html %][% IF ( suggestions_loo.author ) %], by [% suggestions_loo.author | html %][% END %]</a> > <br /> >- [% IF ( suggestions_loo.copyrightdate ) %]© [% suggestions_loo.copyrightdate | html %] [% END %] >- [% IF ( suggestions_loo.volumedesc ) %]; Volume:<em>[% suggestions_loo.volumedesc | html %]</em> [% END %] >- [% IF ( suggestions_loo.isbn ) %]; ISBN:<em>[% suggestions_loo.isbn | html %]</em> [% END %][% IF ( suggestions_loo.publishercode ) %]; Published by [% suggestions_loo.publishercode | html %] [% END %][% IF ( suggestions_loo.publicationyear ) %] in <em>[% suggestions_loo.publicationyear | html %]</em> [% END %][% IF ( suggestions_loo.place ) %] in <em>[% suggestions_loo.place | html %]</em> [% END %][% IF ( suggestions_loo.collectiontitle ) %]; [% suggestions_loo.collectiontitle | html %] [% END %][% IF ( suggestions_loo.itemtype ) %]; [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestions_loo.itemtype, 0 ) | html %] [% END %]<br />[% IF ( suggestions_loo.note ) %]<div class="suggestion_note"><i class="fa fa-comment"></i> [% suggestions_loo.note | html %]</div>[% END %] >+ [% IF ( suggestions_loo.copyrightdate ) %]©<span class="suggestion_copyrightdate"> [% suggestions_loo.copyrightdate | html %]</span> [% END %] >+ [% IF ( suggestions_loo.volumedesc ) %]; <span class="suggestion_volume"Volume:<em>[% suggestions_loo.volumedesc | html %]</em></span> [% END %] >+ [% IF ( suggestions_loo.isbn ) %];<span class="suggestion_isbn"> ISBN:<em>[% suggestions_loo.isbn | html %]</em></span> [% END %][% IF ( suggestions_loo.publishercode ) %];<span class="suggestion_publishercode"> Published by [% suggestions_loo.publishercode | html %]</span> [% END %][% IF ( suggestions_loo.publicationyear ) %]in<span class="suggestion_publicationyear"> <em>[% suggestions_loo.publicationyear | html %]</em></span> [% END %][% IF ( suggestions_loo.place ) %]in <span class="suggestion_place"><em>[% suggestions_loo.place | html %]</em></span> [% END %][% IF ( suggestions_loo.collectiontitle ) %];<span class="suggestion_collectiontitle"> [% suggestions_loo.collectiontitle | html %]</span> [% END %][% IF ( suggestions_loo.itemtype ) %];<span class="suggestion_itype"> [% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestions_loo.itemtype, 0 ) | html %] [% END %]</span><br />[% IF ( suggestions_loo.note ) %]<div class="suggestion_note"><i class="fa fa-comment"></i> [% suggestions_loo.note | html %]</div>[% END %] > [% IF suggestions_loo.archived %]<br /><i class="fa fa-archive"></i> Archived[% END %] > </td> > <td> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27023
:
113635
|
113640
|
114994
|
114995
|
115209
|
115213
|
115214
|
115220
|
115221