There is a lot of info. that goes into the Suggestions column in '/cgi-bin/koha/suggestion/suggestion.pl'. It's currently hard to parse that different information out if you wanted to do something like change the color of the text for each item type. It would be trivial to add class names.
Created attachment 113635 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype
Created attachment 113640 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com>
Created attachment 114994 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com>
Created attachment 114995 [details] [review] Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it)
Typo suggestion_coprightdate
Created attachment 115209 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com>
Hi Lucas, did you see my follow-up patch? Sequence of attachements is wrong now, but not sure if you tested with or without.
Created attachment 115213 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com>
Created attachment 115214 [details] [review] Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it)
(In reply to Katrin Fischer from comment #7) > Hi Lucas, did you see my follow-up patch? Sequence of attachements is wrong > now, but not sure if you tested with or without. Sorry about that. I have tested with your QA follow-up. I the reattached them in the correct order. I am still keeping David's SO line.
Created attachment 115220 [details] [review] Bug 27023: Add class names in acq suggestion table (suggestions column) Test plan: 1. Apply patch 2. Add some suggestions via the OPAC, fill out all the input fields 3. Go to the suggestion managemnet page and look specficially at the Suggestions column. 4. There should be no display change in the table but you should now <span> with classes like 'suggestion_coprightdate', suggestion_isbn, suggestion_publishercode, suggestion_collectiontitle, and suggestion_itype Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 115221 [details] [review] Bug 27023: (QA follow-up) Fix span tags One of the opening tags was missing the > and another was in the wrong spot (started after the IF, but ending outside ouf it) Move spaces around a bit so the strings don't start with spaces. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 21.05, thanks to everybody involved!
Small enhancement, I choose to backport. Pushed to 20.11.x for 20.11.03
Enhancement, not backporting to 20.05. Please ask if needed.