Bugzilla – Attachment 121418 Details for
Bug 20688
Add accesskeys for hold confirmation boxes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 20688: Add accesskeys to hold modals
Bug-20688-Add-accesskeys-to-hold-modals.patch (text/plain), 5.60 KB, created by
Nick Clemens (kidclamp)
on 2021-05-26 10:16:36 UTC
(
hide
)
Description:
Bug 20688: Add accesskeys to hold modals
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2021-05-26 10:16:36 UTC
Size:
5.60 KB
patch
obsolete
>From 55707d1777514b4fd8a5f4c333ecc97c8d9bbb38 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 26 May 2021 09:57:37 +0000 >Subject: [PATCH] Bug 20688: Add accesskeys to hold modals > >This patch adds accesskey elements to the hold modals during checkin > >For tips on how to access the accesskeys: >https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey > >To test: >1 - Place some holds on items >2 - Check in an item with a hold at a branch that requires transfer >3 - Use accesskey I to ignore >4 - Use accesskey Y to confirm and transfer >5 - Check in again >6 - Use accesskey Y to confirm >7 - Repeat 4-6 with a new hold but use the accesskey P to print the slip >8 - Check in the item again ans use accesskey X to cancel >--- > .../intranet-tmpl/prog/en/modules/circ/returns.tt | 28 +++++++++++----------- > 1 file changed, 14 insertions(+), 14 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 0fdb3fd6c6..ab1a0f0d52 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -544,17 +544,17 @@ > <input type="hidden" name="cancel_reserve" value="0" /> > <input id="confirm-hold-barcode" type="hidden" name="barcode" value="[% barcode | html %]" /> > >- <button type="submit" class="btn btn-default approve" data-dismiss="modal"> >- <i class="fa fa-check"></i> Confirm hold >+ <button type="submit" class="btn btn-default approve" data-dismiss="modal" accesskey="y"> >+ <i class="fa fa-check"></i> Confirm hold (Y) > </button> > > <input type="hidden" name="print_slip" value="0" /> >- <button type="button" class="btn btn-default print"> >- <i class="fa fa-print"></i> Print slip and confirm >+ <button type="button" class="btn btn-default print" accesskey="P"> >+ <i class="fa fa-print"></i> Print slip and confirm (P) > </button> > >- <button type="button" class="btn btn-default deny cancel-hold"> >- <i class="fa fa-times"></i> Cancel hold >+ <button type="button" class="btn btn-default deny cancel-hold" accesskey="X"> >+ <i class="fa fa-times"></i> Cancel hold (X) > </button> > </div> <!-- /.modal-footer --> > </form> <!-- /.confirm --> >@@ -712,18 +712,18 @@ > > <div class="modal-footer"> > [% IF ( transfertodo ) %] >- <button type="submit" class="btn btn-default approve"> >- <i class="fa fa-check"></i> Confirm hold and transfer >+ <button type="submit" class="btn btn-default approve" accesskey="y"> >+ <i class="fa fa-check"></i> Confirm hold and transfer (Y) > </button> >- <button type="button" class="btn btn-default print"> >- <i class="fa fa-print"></i> Print slip, transfer, and confirm >+ <button type="button" class="btn btn-default print" accesskey="p"> >+ <i class="fa fa-print"></i> Print slip, transfer, and confirm (P) > </button> > [% ELSE %] >- <button type="submit" class="btn btn-default approve"> >- <i class="fa fa-check"></i> Confirm hold >+ <button type="submit" class="btn btn-default approve" accesskey="y"> >+ <i class="fa fa-check"></i> Confirm hold (Y) > </button> >- <button type="button" class="btn btn-default print"> >- <i class="fa fa-print"></i> Print slip and confirm >+ <button type="button" class="btn btn-default print" accesskey="p"> >+ <i class="fa fa-print"></i> Print slip and confirm (P) > </button> > [% END %] > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 20688
:
121418
|
121419
|
121432
|
121433
|
123295
|
123296
|
124229
|
124230